675567 - Fix PRBool/JSBool mixups

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Michael Wu [:mwu]]

Attachment: Fix

This fixes cases where we use PRBool when we should be using JSBool and vice versa.

It also removes one function where I could not find a user (xpc_SameScope).

Comment 1

[Michael Wu [:mwu]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/81dd021d45bd

Comment 2

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/81dd021d45bd

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 549719 [details] [diff] [review]
Fix

>--- a/js/src/xpconnect/src/xpcwrappednativejsops.cpp
>+++ b/js/src/xpconnect/src/xpcwrappednativejsops.cpp
>                          JSObject **objp)
> {
>     nsresult rv = NS_OK;
>-    JSBool retval = JS_TRUE;
>+    PRBool retval = JS_TRUE;

Could you fix this mismatch?

Comment 4

[Michael Wu [:mwu]]

(In reply to Ms2ger from comment #3)
> Comment on attachment 549719 [details] [diff] [review] [diff] [details] [review]
> Fix
> 
> >--- a/js/src/xpconnect/src/xpcwrappednativejsops.cpp
> >+++ b/js/src/xpconnect/src/xpcwrappednativejsops.cpp
> >                          JSObject **objp)
> > {
> >     nsresult rv = NS_OK;
> >-    JSBool retval = JS_TRUE;
> >+    PRBool retval = JS_TRUE;
> 
> Could you fix this mismatch?

This isn't the only mismatch and I don't care about this sort of mismatch so much. I'll add a s/JS_TRUE/true/ to the sed in bug 675553 and fix all these at the same time.