The default bug view has changed. See this FAQ.

Fix PRBool/JSBool mixups

RESOLVED FIXED in mozilla8

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

Trunk
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 549719 [details] [diff] [review]
Fix

This fixes cases where we use PRBool when we should be using JSBool and vice versa.

It also removes one function where I could not find a user (xpc_SameScope).
Attachment #549719 - Flags: review?(mrbkap)

Updated

6 years ago
Attachment #549719 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 1

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/81dd021d45bd
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/81dd021d45bd
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Comment on attachment 549719 [details] [diff] [review]
Fix

>--- a/js/src/xpconnect/src/xpcwrappednativejsops.cpp
>+++ b/js/src/xpconnect/src/xpcwrappednativejsops.cpp
>                          JSObject **objp)
> {
>     nsresult rv = NS_OK;
>-    JSBool retval = JS_TRUE;
>+    PRBool retval = JS_TRUE;

Could you fix this mismatch?
(Assignee)

Comment 4

6 years ago
(In reply to Ms2ger from comment #3)
> Comment on attachment 549719 [details] [diff] [review] [diff] [details] [review]
> Fix
> 
> >--- a/js/src/xpconnect/src/xpcwrappednativejsops.cpp
> >+++ b/js/src/xpconnect/src/xpcwrappednativejsops.cpp
> >                          JSObject **objp)
> > {
> >     nsresult rv = NS_OK;
> >-    JSBool retval = JS_TRUE;
> >+    PRBool retval = JS_TRUE;
> 
> Could you fix this mismatch?

This isn't the only mismatch and I don't care about this sort of mismatch so much. I'll add a s/JS_TRUE/true/ to the sed in bug 675553 and fix all these at the same time.
You need to log in before you can comment on or make changes to this bug.