Closed Bug 675627 Opened 9 years ago Closed 9 years ago

"error: Unrecognized directive ifndef" in nsIURIRefObject.idl

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla8

People

(Reporter: justin.lebar+bug, Assigned: khuey)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file)

I presume this is related to pyxpidl.  I see this on Windows and Linux.

error: Unrecognized directive ifndef, e:/builds/moz2_slave/try-w32/build/editor/idl/nsIURIRefObject.idl line 38:27
#ifndef nsIURIRefObject_h__
                           ^
error: Unrecognized directive define, e:/builds/moz2_slave/try-w32/build/editor/idl/nsIURIRefObject.idl line 39:27
#define nsIURIRefObject_h__
                           ^
error: Unrecognized directive endif, e:/builds/moz2_slave/try-w32/build/editor/idl/nsIURIRefObject.idl line 80:32
#endif /* nsIURIRefObject_h__ */
This is related to somebody trying to use C++ preprocessor macros to an IDL file incorrectly. They should be removed, since it doesn't make any sense. Although I'm not sure what part of the recent pyxpidl stuff made this parsing more strict.
I'm a little concerned that the build isn't erroring out here ...
Attached patch PatchSplinter Review
This makes the error fatal too.
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #549832 - Flags: review?(benjamin)
Attachment #549832 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/fa54a739294b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.