"error: Unrecognized directive ifndef" in nsIURIRefObject.idl

RESOLVED FIXED in mozilla8

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: khuey)

Tracking

unspecified
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
I presume this is related to pyxpidl.  I see this on Windows and Linux.

error: Unrecognized directive ifndef, e:/builds/moz2_slave/try-w32/build/editor/idl/nsIURIRefObject.idl line 38:27
#ifndef nsIURIRefObject_h__
                           ^
error: Unrecognized directive define, e:/builds/moz2_slave/try-w32/build/editor/idl/nsIURIRefObject.idl line 39:27
#define nsIURIRefObject_h__
                           ^
error: Unrecognized directive endif, e:/builds/moz2_slave/try-w32/build/editor/idl/nsIURIRefObject.idl line 80:32
#endif /* nsIURIRefObject_h__ */
This is related to somebody trying to use C++ preprocessor macros to an IDL file incorrectly. They should be removed, since it doesn't make any sense. Although I'm not sure what part of the recent pyxpidl stuff made this parsing more strict.
I'm a little concerned that the build isn't erroring out here ...
Created attachment 549832 [details] [diff] [review]
Patch

This makes the error fatal too.
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Attachment #549832 - Flags: review?(benjamin)
Attachment #549832 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/projects/build-system/rev/94aa13f4a1a6
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/fa54a739294b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.