675627 - "error: Unrecognized directive ifndef" in nsIURIRefObject.idl

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

I presume this is related to pyxpidl.  I see this on Windows and Linux.

error: Unrecognized directive ifndef, e:/builds/moz2_slave/try-w32/build/editor/idl/nsIURIRefObject.idl line 38:27
#ifndef nsIURIRefObject_h__
                           ^
error: Unrecognized directive define, e:/builds/moz2_slave/try-w32/build/editor/idl/nsIURIRefObject.idl line 39:27
#define nsIURIRefObject_h__
                           ^
error: Unrecognized directive endif, e:/builds/moz2_slave/try-w32/build/editor/idl/nsIURIRefObject.idl line 80:32
#endif /* nsIURIRefObject_h__ */

Comment 1

[Benjamin Smedberg]

This is related to somebody trying to use C++ preprocessor macros to an IDL file incorrectly. They should be removed, since it doesn't make any sense. Although I'm not sure what part of the recent pyxpidl stuff made this parsing more strict.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I'm a little concerned that the build isn't erroring out here ...

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

This makes the error fatal too.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/projects/build-system/rev/94aa13f4a1a6

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/fa54a739294b