675666 - [traceback] AttributeError: 'NoneType' object has no attribute 'all_files'

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Search, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons.allizom.org/z/en-US/firefox/search/es?q=fire&atype=9


traceback details:
 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/vendor/src/django-mobility/mobility/decorators.py", line 23, in wrapper
   return f(request, *args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/search/views.py", line 388, in es_search
   return jingo.render(request, template, ctx)

 File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 79, in render
   rendered = render_to_string(request, template, context)

 File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 97, in render_to_string
   return template.render(**get_context())

 File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/amo_python/www/preview/zamboni/apps/search/templates/search/es_results.html", line 22, in top-level template code
   {% for link in links recursive %}

 File "/data/amo_python/www/preview/zamboni/templates/impala/base.html", line 140, in top-level template code
   {% block main_content %}

 File "/data/amo_python/www/preview/zamboni/templates/impala/base.html", line 145, in block "main_content"
   {% block content %}{% endblock %}

 File "/data/amo_python/www/preview/zamboni/apps/search/templates/search/es_results.html", line 63, in block "content"
   {{ impala_addon_listing_items(pager.object_list, show_date=query.sort,

 File "/data/amo_python/www/preview/zamboni/vendor/src/jingo/jingo/__init__.py", line 147, in wrapper
   t = env.get_template(template).render(context)

 File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/amo_python/www/preview/zamboni/apps/addons/templates/addons/impala/listing/items.html", line 1, in top-level template code
   {% cache addons %}

 File "/data/amo_python/www/preview/zamboni/apps/amo/ext.py", line 18, in _cache_support
   return caller()

 File "/data/amo_python/www/preview/zamboni/apps/addons/templates/addons/impala/listing/items.html", line 8, in template
   {% if addon.is_no_restart() %}

 File "/data/amo_python/www/preview/zamboni/apps/addons/models.py", line 739, in is_no_restart
   files = self.current_version.all_files

AttributeError: 'NoneType' object has no attribute 'all_files'

Comment 1

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/cc258b9

Comment 2

[krupa raj[:krupa]]

verified fixed at https://addons.allizom.org/z/en-US/firefox/search/es?q=fire&atype=9