675709 - printToFile is busted on Mac

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Install https://www.squarefree.com/extensions/domFuzzLite2.xpi
2. Load the testcase.

Result on Windows and Linux: creates "fuzzout.pdf" in the Firefox profile dir :)

Result on Mac: sends my page to the nearest office printer :(

This bug makes it impossible to test Mac printing code, which is why I didn't catch topcrash bug 665218 with my dom fuzzer and why that bug still has no regression test.

(This is an old bug; the problem was mentioned in bug 299129 comment 0.)

Comment 1

[(no longer active)]

Don't know who's working on printing bugs these days...

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This is really OSX widget level stuff.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Let me provisionally assign this to myself.  I don't know when I'll get to it, but it sounds like the kind of stuff I normally work on.

Comment 4

[Zack Weinberg (:zwol)]

Whoever gets around to working on this, please take note of the spring cleaning in bug 629500.  I am making this a dependency of that because follow-up work that I have planned for that bug might wind up fixing this as a side-effect, so I don't want to lose it.  However, please don't take this as a statement of intent to fix this bug, and don't hesitate to drop the dependency if you fix it before that bug lands.

Comment 5

[Hiroshi Hatake [:cosmo0920]]

Dose anyone work this bug in these days?
I've got succeeded obtaining PDF file with my patch when specified printToFile, toFileName, and printSilent in nsIPrintSettings.
And I want to submit my patch.

Comment 6

[Markus Stange [:mstange]]

Nobody is working on this at the moment. I've assigned it to you.

Comment 7

[Hiroshi Hatake [:cosmo0920]]

Attachment: Initial revision of set-needed-information-when-printing-into-PDF-file.diff

Comment 8

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-needed-information-when-printing-into-PDF-file-v2.diff

Previous patch didn't call nsPrintSettingsX::InitAdjustedPaperSize() when changing page format. This patch calls it when changing page format in nsDeviceContextSpecX::Init.

Comment 9

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-needed-information-when-printing-into-PDF-file-v3.diff

Add missing converting units.
Inch -> Pixels.

Comment 10

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-needed-information-when-printing-into-PDF-file-v4.diff

Fix wrong units descriptions in comment.

Comment 11

[Hiroshi Hatake [:cosmo0920]]

Current patch implementation does not use `GetEffectivePageSize()`, which depends on cairo context size, because cairo context too large on macOS.
If we want to use correct internal papar size via `GetEffectivePageSize()`, we should fix "Surface size too large" warnings.

Comment 12

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-needed-information-when-printing-into-PDF-file-v5.diff

Avoid to use hardcorded PPI value.

Comment 13

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-unwriteable-margin-settings-when-printing-into-PDF-file-v1.diff

I've found another issue when printing to PDF,.
In macOS, unwriteable margin settings does not apply into Core Printing API.
(Although, traditional macOS printing is not affected by this issue because printing modal dialog's advanced settings covers this feature.)
We also should apply this patch if implementing printToFile feature on macOS.

Comment 14

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-unwriteable-margin-settings-API-for-macOS-v1.diff

Comment 15

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-needed-information-when-printing-into-PDF-file-v6.diff

I've cleaned up previous patches implementations.

Comment 16

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-needed-information-when-printing-into-PDF-file-v7.diff

More cleaning up patch.

Comment 17

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-needed-information-when-printing-into-PDF-file-v8.diff

Comment 18

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-needed-information-when-printing-into-PDF-file-v9.diff

Comment 19

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8829088 [details] [diff] [review]
set-needed-information-when-printing-into-PDF-file-v9.diff

Hey haik - do you have the cycles to review this?

Comment 20

[Haik Aftandilian [:haik]]

(In reply to Mike Conley (:mconley) from comment #19)
> Comment on attachment 8829088 [details] [diff] [review]
> set-needed-information-when-printing-into-PDF-file-v9.diff
> 
> Hey haik - do you have the cycles to review this?

Sure, I'll get to this by the end of the week.

Comment 21

[Mike Conley (:mconley) (:⚙️)]

Awesome - thank you. :)

Comment 22

[Haik Aftandilian [:haik]]

(In reply to Haik Aftandilian [:haik] from comment #20)
> (In reply to Mike Conley (:mconley) from comment #19)
> > Comment on attachment 8829088 [details] [diff] [review]
> > set-needed-information-when-printing-into-PDF-file-v9.diff
> > 
> > Hey haik - do you have the cycles to review this?
> 
> Sure, I'll get to this by the end of the week.

Sorry, need some more time on this one.

Comment 23

[Haik Aftandilian [:haik]]

Comment on attachment 8829088 [details] [diff] [review]
set-needed-information-when-printing-into-PDF-file-v9.diff

Review of attachment 8829088 [details] [diff] [review]:
-----------------------------------------------------------------

This looks OK to me, but I tried Jesse's attached testcase and it didn't work for me. Does it work for you?

(Keep in mind I'm not very knowledgeable about Mac widget code or Objective-C.)

Comment 24

[Hiroshi Hatake [:cosmo0920]]

Thanks for reviewing this.
Unfortunately, with Firefox 50.0.1, I did not succeed to work Jesse's attached test case on macOS even if Ubuntu 14.04.5.

Comment 25

[Hiroshi Hatake [:cosmo0920]]

I've also confirmed that e10s-ized content process does not load extension's components and non-e10s window blocks with privileged or cross-origin callable error now.
The testcase is not working anymore....

Comment 26

[Hiroshi Hatake [:cosmo0920]]

I've found confirmation step with attached addon:

1. Set xpinstall.signatures.required to false
2. Install attached testcase addon
3. Open non-e10s-ized window with New Non-e10s
4. Open new empty tab
5. appmenu -> Developer -> Toggle Tools
6. Type `fuzzPriv.printToFile(true, false, false, false)` in Console
7. Confirm to be created fuzzout.pdf within profile folder

Comment 27

[Hiroshi Hatake [:cosmo0920]]

Can I add checkin-needed keyword?

Comment 28

[Haik Aftandilian [:haik]]

Yes, thanks for looking into that.

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2114a592360d
Create needed API when printing info PDF on macOS. r=haik
https://hg.mozilla.org/integration/mozilla-inbound/rev/d88c174c2d20
Set needed paper size information when printing info PDF on macOS. r=haik

Comment 30

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Sorry, I had to back this out for build bustage on OS X because of use of undeclared identifiers:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9436c71aecf1598172748722c48d87a1ac0894d6
https://hg.mozilla.org/integration/mozilla-inbound/rev/31590ab43f619f595a0edef9acf4492e457ed92d

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d88c174c2d20fe3f20b2c7bc5ffe73a154c5079f
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=74604888&repo=mozilla-inbound

 /builds/slave/m-in-m64-000000000000000000000/build/src/widget/cocoa/nsPrintSettingsX.mm:337:35: error: use of undeclared identifier 'NSPaperOrientationPortrait'
/builds/slave/m-in-m64-000000000000000000000/build/src/widget/cocoa/nsPrintSettingsX.mm:352:56: error: use of undeclared identifier 'NSPaperOrientationPortrait'
/builds/slave/m-in-m64-000000000000000000000/build/src/widget/cocoa/nsPrintSettingsX.mm:355:56: error: use of undeclared identifier 'NSPaperOrientationLandscape'
/builds/slave/m-in-m64-000000000000000000000/build/src/widget/cocoa/nsPrintSettingsX.mm:474:35: error: use of undeclared identifier 'NSPaperOrientationPortrait'

Please fix the issue and submit an updated patch.

Comment 31

[Hiroshi Hatake [:cosmo0920]]

Attachment: set-needed-information-when-printing-into-PDF-file-v10.diff

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd49b1d1bf8f
Export the constants for paper orientation. r=haik

Comment 33

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dd49b1d1bf8f