675742 - Can no longer cancel default context menu action on content right click

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[Heather Arthur [:harth]]

My addon adds some click handlers to the content, one of them is a right click handler and it cancels the default "open content-area context menu" action:

https://github.com/harthur/rainbow/blob/master/chrome/content/inspector.js#L190

This used to work in Firefox 4, but it was regressed with the landing of bug 426643. Now if you right click it will perform the action then open the context menu, not behavior my addon wants.

Comment 1

[Heather Arthur [:harth]]

regression range:

Last good nightly: 2011-06-01
First bad nightly: 2011-06-02

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5c6d107ede5a&tochange=9a6c139a4e58

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Have you confirmed that the patch for bug 426643 causes/triggers this bug?  In other words, does reversing that patch make this bug go away?

Does your addon's right click handler work properly on other platforms (like Windows and Linux)?

Comment 3

[Heather Arthur [:harth]]

(In reply to comment #2)
> Have you confirmed that the patch for bug 426643 causes/triggers this bug? 
> In other words, does reversing that patch make this bug go away?
> 
> Does your addon's right click handler work properly on other platforms (like
> Windows and Linux)?

Doesn't happen on Windows. Happens on Linux (since 2010 nightlies at least). I don't have a build right now but that by far looks like the culprit in that regression range.

Comment 4

[Heather Arthur [:harth]]

(In reply to comment #0)
> My addon adds some click handlers to the content, one of them is a right
> click handler and it cancels the default "open content-area context menu"
> action:
> 
> https://github.com/harthur/rainbow/blob/master/chrome/content/inspector.
> js#L190
> 

My bad, the code is here: 
https://github.com/harthur/rainbow/blob/0a7520d8907cf88ea1ad33c258ec6584c6874bd4/chrome/content/inspector.js#L169

Comment 5

[Wayne Mery (:wsmwk)]

Any reason to believe this still exists?

Comment 6

[Stephen A Pohl [:spohl]]

This has most likely been fixed by now. If this is still an issue, please reopen.