First Last does not have a comma

RESOLVED FIXED in Thunderbird 10.0

Status

Thunderbird
Address Book
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sid0, Assigned: timeless)

Tracking

unspecified
Thunderbird 10.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Created attachment 549949 [details] [diff] [review]
patch

(courtesy timeless)
Attachment #549949 - Flags: review?(mbanner)
Comment on attachment 549949 [details] [diff] [review]
patch

I'm not really happy with how "First Last" reads, but I agree that the comma shouldn't be there.  So, unasked-for-ui-r=me.  ;)

Later,
Blake.
Attachment #549949 - Flags: ui-review+
Comment on attachment 549949 [details] [diff] [review]
patch

Whilst we're not changing the context, as we seem to agree that without the comma makes sense, then we also want to make sure locales get updated. At 55 locales with the comma and 12 locales without, I think it would be worth updating the string id (and syncing the .accesskey) rather than filing lots of bugs.

I think we should also have an l10n comment explaining why we're not including the comma even though it is sort-of-natural to have it.
Attachment #549949 - Flags: review?(mbanner) → review-
(Reporter)

Comment 3

6 years ago
Created attachment 559428 [details] [diff] [review]
updated patch fixing comment
Attachment #549949 - Attachment is obsolete: true
Attachment #559428 - Flags: review?(mbanner)
Did you miss adding a file to the diff?
(Reporter)

Comment 5

6 years ago
Created attachment 562075 [details] [diff] [review]
updated patch adding missing file

yeah, oops.
Attachment #559428 - Attachment is obsolete: true
Attachment #559428 - Flags: review?(mbanner)
Attachment #562075 - Flags: review?(mbanner)
Attachment #562075 - Flags: review?(mbanner) → review+
(Reporter)

Comment 6

6 years ago
https://hg.mozilla.org/comm-central/rev/f5a33f4b3f2b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in before you can comment on or make changes to this bug.