Last Comment Bug 675804 - e10s HTTP redirects - test_bug397427 fails in Fennec
: e10s HTTP redirects - test_bug397427 fails in Fennec
Status: RESOLVED FIXED
: testcase
Product: Core
Classification: Components
Component: Networking: HTTP (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla8
Assigned To: Honza Bambas (:mayhemer)
:
Mentors:
http://www.kantjils.nl/moz/mochitestj...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-01 16:43 PDT by Martijn Wargers [:mwargers] (gone per 2016-05-31 :-( )
Modified: 2011-10-13 19:43 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (1.71 KB, patch)
2011-08-02 13:30 PDT, Honza Bambas (:mayhemer)
jduell.mcbugs: review+
Details | Diff | Review

Description Martijn Wargers [:mwargers] (gone per 2016-05-31 :-( ) 2011-08-01 16:43:32 PDT
See bug 397427 of why I made this bug security sensitive.
Fennec is failing some of the tests in test_bug397427.html, making it susceptible to those attacks, afaict. (although the description in bug 397427 sounds rather vague  to me, and since Fennec hasn't gained major marketshare, I would think this bug can be unhidden).

See testcase here:
http://www.kantjils.nl/moz/mochitestjs/select.html

It should say (and Firefox desktop does):
style.sheet.cssRules[0].styleSheet.href: http://www.kantjils.nl/moz/mochitestjs/bodyred.css
style.sheet.cssRules[1].styleSheet.href: http://www.kantjils.nl/moz/mochitestjs/redirect.php?bodygreen.css
c.href:c.sheet.href http://www.kantjils.nl/moz/mochitestjs/redirect.php?bodygreen.css:http://www.kantjils.nl/moz/mochitestjs/redirect.php?bodygreen.css

But in Fennec it does say:
style.sheet.cssRules[0].styleSheet.href: http://www.kantjils.nl/moz/mochitestjs/bodyred.css
style.sheet.cssRules[1].styleSheet.href: http://www.kantjils.nl/moz/mochitestjs/bodygreen.css
c.href:c.sheet.href http://www.kantjils.nl/moz/mochitestjs/redirect.php?bodygreen.css:http://www.kantjils.nl/moz/mochitestjs/bodygreen.css

Here is the original mochitest, btw, which partly fail in Fennec:
http://www.kantjils.nl/moz/mochitestjs/test_bug397427.html
Comment 1 Honza Bambas (:mayhemer) 2011-08-02 13:10:34 PDT
We badly set mOriginalURI on redirected child channel on the content process.  I will check why, probably my fault.

When exactly this started to appear?  Wasn't it always failing?
Comment 2 Honza Bambas (:mayhemer) 2011-08-02 13:30:53 PDT
Created attachment 550182 [details] [diff] [review]
v1

Not sure why I have introduced the new member, but it is apparently always left null.
Comment 3 Josh Matthews [:jdm] 2011-08-02 13:31:39 PDT
This is probably one of the many tests we haven't been running. I'm not even certain that it's in the tests we're running right now.
Comment 4 Martijn Wargers [:mwargers] (gone per 2016-05-31 :-( ) 2011-08-03 08:11:45 PDT
Yes, the plan is to enable the layout/style/test/ mochitests, but we need to figure out which ones are failing, first. And then fix the tests or disable them otherwise.
Comment 5 Martijn Wargers [:mwargers] (gone per 2016-05-31 :-( ) 2011-08-04 06:54:08 PDT
Would this also fix this case? http://www.kantjils.nl/moz/mochitestjs/body_onload_script_redirect.html
That page never stops loading in Fennec, it works fine in Firefox.

This is probably the cause for failures in:
http://mxr.mozilla.org/mozilla-central/source/layout/style/test/test_visited_image_loading.html?force=1
Comment 6 Honza Bambas (:mayhemer) 2011-08-04 13:13:39 PDT
(In reply to comment #5)
> Would this also fix this case?
> http://www.kantjils.nl/moz/mochitestjs/body_onload_script_redirect.html
> That page never stops loading in Fennec, it works fine in Firefox.
> 

The patch has no affect on this issue.

> This is probably the cause for failures in:
> http://mxr.mozilla.org/mozilla-central/source/layout/style/test/
> test_visited_image_loading.html?force=1

I can see "ASSERTION: Redirecting to a protocol that doesn't support universal protocol redirect"  when running the test.  If that is cause of the test failure then it is quit different issue.  See https://bugzilla.mozilla.org/show_bug.cgi?id=661604#c2 that might be related.

However, we should track all "universal protocol redirect" failing tests and fix the code ; in a different bug.
Comment 7 Martijn Wargers [:mwargers] (gone per 2016-05-31 :-( ) 2011-08-04 15:12:03 PDT
Yes, bug 661604 sounds exactly what http://www.kantjils.nl/moz/mochitestjs/body_onload_script_redirect.html is suffering from in Fennec.
Comment 8 Honza Bambas (:mayhemer) 2011-08-08 05:21:55 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/e6ea47d9134e
Comment 9 :Ehsan Akhgari (busy, don't ask for review please) 2011-08-09 08:51:17 PDT
http://hg.mozilla.org/mozilla-central/rev/e6ea47d9134e

Note You need to log in before you can comment on or make changes to this bug.