Permission for moving pages

RESOLVED FIXED

Status

P3
enhancement
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: openjck, Unassigned)

Tracking

(Blocks: 1 bug)

Details

(Whiteboard: [user-interview][type:feature][triaged])

(Reporter)

Description

7 years ago
Please see the following comment for the motivation behind this request:

https://bugzilla.mozilla.org/show_bug.cgi?id=675795#c0
(Reporter)

Updated

7 years ago
Priority: P4 → P3
(Reporter)

Comment 1

7 years ago
This permission should not be granted to ordinary users.
Depends on: 677814
Summary: Do not allow ordinary users to move pages → Permission for moving pages
(Reporter)

Updated

7 years ago
Whiteboard: u=administrator c=siteadmin p= → [user-interview] u=administrator c=siteadmin p=

Updated

7 years ago
Blocks: 757245
Priority: P3 → P2

Updated

7 years ago
Blocks: 756266
No longer blocks: 757245
Priority: P2 → P3
This is currently open to all, in Kuma. 

To gate it with access control, I think we'd wrap the ability to change title and slug with a permission. Slug actually changes the URL, but we might as well cover title too.

One question: Should a user be able to move/rename a page he or she created?

Comment 3

7 years ago
I think yes. I don't know if Kuma still has a "user sandbox", but a user should be able to create a page in a scratch area, and move it into its "real" location when it's "done". Or they may realize that they created a page in the "wrong" location; letting them move it without bugging anybody would be good.

In that case, the key thing is making the move dialog more self-explanatory than in MindTouch. MT's move dialog confuses people and causes them to do the wrong thing.
(Assignee)

Updated

6 years ago
Version: Kuma → unspecified
(Assignee)

Updated

6 years ago
Component: Website → Landing pages
Product: Mozilla Developer Network → Mozilla Developer Network
(Reporter)

Updated

6 years ago
No longer blocks: 756266

Updated

6 years ago
Depends on: 764431
No longer depends on: 677814
(Reporter)

Updated

6 years ago
Component: Landing pages → User management
Whiteboard: [user-interview] u=administrator c=siteadmin p= → [user-interview]
(Reporter)

Comment 4

5 years ago
Les, do you think we should keep this open? IIRC we manage this "permission" with Waffle currently, but I know that may not be the best solution.
Flags: needinfo?(lorchard)
(Reporter)

Updated

5 years ago
Severity: normal → enhancement
Whiteboard: [user-interview] → [user-interview][type:feature][triaged]
(In reply to John Karahalis [:openjck] from comment #4)
> Les, do you think we should keep this open? IIRC we manage this "permission"
> with Waffle currently, but I know that may not be the best solution.

Waffle should only ever be thought of as a temporary gate to a feature in testing. We should never consider it permission control.
Flags: needinfo?(lorchard)
We need to get this tied to the "Can move a tree of pages" permission now, so we can start letting trusted localizers move pages to keep up with the massive reorg the English content is undergoing. Can we get this done in the next few days, please?
This would be good, even if we didn't foresaw how much this would be needed with the reorg; ideally we would like to have this for next Saturday (Paris l10n Sprint Week-end)

Feedbacking Maris.
Flags: needinfo?(mars)
James, Les, what do you think about comment 6?  Would it be possible to tie the permissions together in time for the docs sprint on April 26th?
Flags: needinfo?(mars)
Flags: needinfo?(lorchard)
Flags: needinfo?(jbennett)
(In reply to Māris Fogels [:mars] from comment #8)
> James, Les, what do you think about comment 6?  Would it be possible to tie
> the permissions together in time for the docs sprint on April 26th?

I'm not really familiar with page move, but what we could probably do by then is:

1) Wrap the feature in a Django permission

2) Create a new user group, grant the permission to the group

3) Add users as needed to the group via Django admin

That would require whomever wants to share the permission to get comfortable navigating Django admin views & adding users to a group. Anything more user friendly is on a much farther horizon.
Flags: needinfo?(lorchard)
I can get this together in the next couple days.
Flags: needinfo?(jbennett)
Assignee: nobody → jbennett
Assignee: jbennett → nobody

Comment 11

5 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/70b658ba3b9d6567309f91ae51bb01305276ccd6
Bug 675842: Remove waffle flag for page move.

This removes the waffle flag check that controls access to the page
move view; going forward, access will be controlled by the permissions
infrastructure.

https://github.com/mozilla/kuma/commit/eb926aefdab2fdaa78c2ad7998c94f66ccb0459e
Merge pull request #2322 from ubernostrum/page-move-no-waffle

Bug 675842: Remove waffle flag for page move.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.