675846 - Webifyme: [traceback] NameError: global name '_' is not defined

Status: VERIFIED FIXED

(Websites :: webifyme.org, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

With the following POST to https://webifyme-dev.allizom.org/en-US/quiz/, POST:<QueryDict: {u'download_reminder': [u'on'], u'csrfmiddlewaretoken': [u'd2597fe862fd419484a35a7d7deb6ac6'], u'gallery_include': [u'on'], u'name': [u''], u'email': [u'']}>,, I get:

Traceback (most recent call last):

  File "/data/www/python/webifyme.org/webifyme/ff4/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/python/webifyme.org/webifyme/ff4/things/views.py", line 278, in quiz
    if not form.is_valid():

  File "/data/www/python/webifyme.org/webifyme/ff4/vendor/src/django/django/forms/forms.py", line 121, in is_valid
    return self.is_bound and not bool(self.errors)

  File "/data/www/python/webifyme.org/webifyme/ff4/vendor/src/django/django/forms/forms.py", line 112, in _get_errors
    self.full_clean()

  File "/data/www/python/webifyme.org/webifyme/ff4/vendor/src/django/django/forms/forms.py", line 267, in full_clean
    self._clean_fields()

  File "/data/www/python/webifyme.org/webifyme/ff4/vendor/src/django/django/forms/forms.py", line 287, in _clean_fields
    value = getattr(self, 'clean_%s' % name)()

  File "/data/www/python/webifyme.org/webifyme/ff4/../ff4/things/forms.py", line 21, in clean_download_reminder
    raise forms.ValidationError(_('Download reminder requires email.'))

NameError: global name '_' is not defined

Comment 1

[[:brez]]

Just missing the import statement:

https://github.com/mozilla/webifyme/commit/eff9052961002ecc9bb55b7e3d931343aa8e4d08

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://webifyme-dev.allizom.org; thanks!