Closed Bug 675858 Opened 9 years ago Closed 9 years ago

Error: Services is not defined chrome://navigator/content/pageinfo/permissions.js

Categories

(SeaMonkey :: Page Info, defect)

defect
Not set

Tracking

(seamonkey2.4 fixed, seamonkey2.5 fixed, seamonkey2.6 fixed)

RESOLVED FIXED
seamonkey2.6
Tracking Status
seamonkey2.4 --- fixed
seamonkey2.5 --- fixed
seamonkey2.6 --- fixed

People

(Reporter: philip.chee, Assigned: stanio)

References

Details

(Keywords: regression, Whiteboard: [good first bug])

Attachments

(1 file)

Error: Services is not defined
Source file: chrome://navigator/content/pageinfo/permissions.js
Line: 38

In pageInfo.xul I think utilityOverlay.js should come before any calls to Services.
Whiteboard: [good first bug]
Attached patch Suggested patchSplinter Review
Per comment #0 moved the inclusion of utilityOverlay.js before any calls to Services.  I've identified this should be just prior pageInfo.js.  It appears to fix the issue for me (no errors in the Error Console) and the Live HTTP Headers extension tab in the Page Info now shows the headers just fine.
Attachment #556301 - Flags: review?(db48x)
Comment on attachment 556301 [details] [diff] [review]
Suggested patch

I have not verified that this fixes the bug, but I do know this won't break anything, so lets call it good, and VERIFY once this lands.
Attachment #556301 - Flags: review?(db48x)
Attachment #556301 - Flags: review+
Attachment #556301 - Flags: approval-comm-beta+
Attachment #556301 - Flags: approval-comm-aurora+
Keywords: checkin-needed
Assignee: nobody → stanio
Pushed:
http://hg.mozilla.org/comm-central/rev/5d1bb791ad9d
http://hg.mozilla.org/releases/comm-aurora/rev/06cd5532ae61
http://hg.mozilla.org/releases/comm-beta/rev/63c6090eb921

Thank you Stanimir! Sorry I missed this one.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.