remove nsIAccessible::relationsCount and getRelation()

RESOLVED FIXED in mozilla9

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: surkov, Assigned: marco)

Tracking

(Blocks: 1 bug, {access})

Trunk
mozilla9
access
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
getRelationByType and getRelations() are enough
(Assignee)

Comment 1

6 years ago
Created attachment 556099 [details] [diff] [review]
Patch
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #556099 - Flags: review?(surkov.alexander)
(In reply to Marco Castelluccio from comment #1)
> Created attachment 556099 [details] [diff] [review]
> Patch

uh, you  missed GetRelationsCount().  Also you  need to update the uiid for nsIAccessible.(In reply to Marco Castelluccio from comment #1)
> Created attachment 556099 [details] [diff] [review]
> Patch

uh, you missed the impl of GetRelationsCount() all together, and you need to update the uiid of nsIAccessible.
(Assignee)

Comment 3

6 years ago
Created attachment 556161 [details] [diff] [review]
Patch v2
Attachment #556099 - Attachment is obsolete: true
Attachment #556099 - Flags: review?(surkov.alexander)
Attachment #556161 - Flags: review?(surkov.alexander)
(Reporter)

Comment 4

6 years ago
Comment on attachment 556161 [details] [diff] [review]
Patch v2

r=me, thank you for doing this
Attachment #556161 - Flags: review?(surkov.alexander) → review+
(Reporter)

Comment 5

6 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> (In reply to Marco Castelluccio from comment #1)
> > Created attachment 556099 [details] [diff] [review]
> > Patch
> 
> uh, you  missed GetRelationsCount().  Also you  need to update the uiid for
> nsIAccessible.

Trevor, thank you for review.
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 6

6 years ago
In my queue with a few other bits that are being sent to try first and then onto inbound.
Flags: in-testsuite-
Keywords: checkin-needed
Version: unspecified → Trunk

Comment 7

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/02d69f92b42e
Target Milestone: --- → mozilla9

Comment 8

6 years ago
http://hg.mozilla.org/mozilla-central/rev/02d69f92b42e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.