Last Comment Bug 675870 - remove nsIAccessible::relationsCount and getRelation()
: remove nsIAccessible::relationsCount and getRelation()
Status: RESOLVED FIXED
: access
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Marco Castelluccio [:marco]
:
Mentors:
Depends on:
Blocks: cleanxpcoma11y
  Show dependency treegraph
 
Reported: 2011-08-01 23:46 PDT by alexander :surkov
Modified: 2011-08-28 13:33 PDT (History)
2 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.27 KB, patch)
2011-08-26 12:28 PDT, Marco Castelluccio [:marco]
no flags Details | Diff | Splinter Review
Patch v2 (3.43 KB, patch)
2011-08-26 15:54 PDT, Marco Castelluccio [:marco]
surkov.alexander: review+
Details | Diff | Splinter Review

Description alexander :surkov 2011-08-01 23:46:03 PDT
getRelationByType and getRelations() are enough
Comment 1 Marco Castelluccio [:marco] 2011-08-26 12:28:01 PDT
Created attachment 556099 [details] [diff] [review]
Patch
Comment 2 Trevor Saunders (:tbsaunde) 2011-08-26 13:11:05 PDT
(In reply to Marco Castelluccio from comment #1)
> Created attachment 556099 [details] [diff] [review]
> Patch

uh, you  missed GetRelationsCount().  Also you  need to update the uiid for nsIAccessible.(In reply to Marco Castelluccio from comment #1)
> Created attachment 556099 [details] [diff] [review]
> Patch

uh, you missed the impl of GetRelationsCount() all together, and you need to update the uiid of nsIAccessible.
Comment 3 Marco Castelluccio [:marco] 2011-08-26 15:54:18 PDT
Created attachment 556161 [details] [diff] [review]
Patch v2
Comment 4 alexander :surkov 2011-08-26 18:43:42 PDT
Comment on attachment 556161 [details] [diff] [review]
Patch v2

r=me, thank you for doing this
Comment 5 alexander :surkov 2011-08-26 18:47:38 PDT
(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> (In reply to Marco Castelluccio from comment #1)
> > Created attachment 556099 [details] [diff] [review]
> > Patch
> 
> uh, you  missed GetRelationsCount().  Also you  need to update the uiid for
> nsIAccessible.

Trevor, thank you for review.
Comment 6 Ed Morley [:emorley] 2011-08-27 03:37:06 PDT
In my queue with a few other bits that are being sent to try first and then onto inbound.
Comment 8 Ed Morley [:emorley] 2011-08-28 13:33:23 PDT
http://hg.mozilla.org/mozilla-central/rev/02d69f92b42e

Note You need to log in before you can comment on or make changes to this bug.