Closed
Bug 675870
Opened 11 years ago
Closed 11 years ago
remove nsIAccessible::relationsCount and getRelation()
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: surkov, Assigned: marco)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file, 1 obsolete file)
3.43 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
getRelationByType and getRelations() are enough
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #556099 -
Flags: review?(surkov.alexander)
Comment 2•11 years ago
|
||
(In reply to Marco Castelluccio from comment #1) > Created attachment 556099 [details] [diff] [review] > Patch uh, you missed GetRelationsCount(). Also you need to update the uiid for nsIAccessible.(In reply to Marco Castelluccio from comment #1) > Created attachment 556099 [details] [diff] [review] > Patch uh, you missed the impl of GetRelationsCount() all together, and you need to update the uiid of nsIAccessible.
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #556099 -
Attachment is obsolete: true
Attachment #556099 -
Flags: review?(surkov.alexander)
Attachment #556161 -
Flags: review?(surkov.alexander)
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 556161 [details] [diff] [review] Patch v2 r=me, thank you for doing this
Attachment #556161 -
Flags: review?(surkov.alexander) → review+
Reporter | ||
Comment 5•11 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #2) > (In reply to Marco Castelluccio from comment #1) > > Created attachment 556099 [details] [diff] [review] > > Patch > > uh, you missed GetRelationsCount(). Also you need to update the uiid for > nsIAccessible. Trevor, thank you for review.
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
In my queue with a few other bits that are being sent to try first and then onto inbound.
Comment 7•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/02d69f92b42e
Target Milestone: --- → mozilla9
Comment 8•11 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/02d69f92b42e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•