Closed Bug 675870 Opened 8 years ago Closed 8 years ago

remove nsIAccessible::relationsCount and getRelation()

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: surkov, Assigned: marco)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

getRelationByType and getRelations() are enough
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #556099 - Flags: review?(surkov.alexander)
(In reply to Marco Castelluccio from comment #1)
> Created attachment 556099 [details] [diff] [review]
> Patch

uh, you  missed GetRelationsCount().  Also you  need to update the uiid for nsIAccessible.(In reply to Marco Castelluccio from comment #1)
> Created attachment 556099 [details] [diff] [review]
> Patch

uh, you missed the impl of GetRelationsCount() all together, and you need to update the uiid of nsIAccessible.
Attached patch Patch v2Splinter Review
Attachment #556099 - Attachment is obsolete: true
Attachment #556099 - Flags: review?(surkov.alexander)
Attachment #556161 - Flags: review?(surkov.alexander)
Comment on attachment 556161 [details] [diff] [review]
Patch v2

r=me, thank you for doing this
Attachment #556161 - Flags: review?(surkov.alexander) → review+
(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> (In reply to Marco Castelluccio from comment #1)
> > Created attachment 556099 [details] [diff] [review]
> > Patch
> 
> uh, you  missed GetRelationsCount().  Also you  need to update the uiid for
> nsIAccessible.

Trevor, thank you for review.
In my queue with a few other bits that are being sent to try first and then onto inbound.
Flags: in-testsuite-
Keywords: checkin-needed
Version: unspecified → Trunk
http://hg.mozilla.org/mozilla-central/rev/02d69f92b42e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.