Last Comment Bug 675961 - Websockets - error in removing processed control frame from buffered fragment sequence
: Websockets - error in removing processed control frame from buffered fragmen...
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Networking: WebSockets (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla8
Assigned To: Patrick McManus [:mcmanus]
:
Mentors:
Depends on:
Blocks: 664344
  Show dependency treegraph
 
Reported: 2011-08-02 09:00 PDT by Patrick McManus [:mcmanus]
Modified: 2011-08-05 09:08 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch 1 (1.50 KB, patch)
2011-08-02 09:05 PDT, Patrick McManus [:mcmanus]
jduell.mcbugs: review+
Details | Diff | Splinter Review

Description Patrick McManus [:mcmanus] 2011-08-02 09:00:41 PDT
from bug 664344 - a description of receiving first-frag, ping, last-frag causing multiple pongs in response along with general wonkiness.

problem is in removing the ping from the fragment frame, length reset to 0 before a calculation was made.

1 line fix.
Comment 1 Patrick McManus [:mcmanus] 2011-08-02 09:05:26 PDT
Created attachment 550099 [details] [diff] [review]
patch 1

This fixes tests 3.6 and 3.7 from https://github.com/oberstet/Autobahn
Comment 2 Jason Duell [:jduell] (needinfo me) 2011-08-04 22:50:38 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/840fd3069d1f
Comment 3 Marco Bonardo [::mak] 2011-08-05 09:08:29 PDT
http://hg.mozilla.org/mozilla-central/rev/840fd3069d1f

Note You need to log in before you can comment on or make changes to this bug.