675977 - enable mobile talos by default for branches and project branches

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mike Taylor [:bear]]

Enable all remote-* talos tests by default

Comment 1

[Mike Taylor [:bear]]

Attachment: enable remote-* talos tests by default

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 550111 [details] [diff] [review]
enable remote-* talos tests by default

I think the config.py portion looks good, but why does your diff have a wholly new project_branches.py ?

Comment 3

[Mike Taylor [:bear]]

(In reply to comment #2)
> Comment on attachment 550111 [details] [diff] [review] [diff] [details] [review]
> enable remote-* talos tests by default
> 
> I think the config.py portion looks good, but why does your diff have a
> wholly new project_branches.py ?

not sure ... let me pull a fresh version and double-check

Comment 4

[Mike Taylor [:bear]]

Attachment: enable remote-* talos tests by default

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 550158 [details] [diff] [review]
enable remote-* talos tests by default

>-    # Want to turn on/off a talos suite? Set it in the PROJECT_BRANCHES[branch]['talos_suites'] otherwise, defaults below
>-    if branchConfig.get('talos_suites'):
>-        talosConfig = branchConfig['talos_suites']
>-    else:
>-        # This is the default and will make all talosConfig.get(key,0) calls
>-        # to default to 0 a.k.a. disabled suite
>-        talosConfig = {}
>-

I think we still want to be able to do this; it's just that we won't have anything except maybe v8.
Let's keep this, I think.

>     for suite in SUITES.keys():
>         if not SUITES[suite]['enable_by_default']:
>             # Suites that are turned off by default
>-            BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 0), ) + SUITES[suite]['options']
>+            BRANCHES[branch][suite + '_tests'] = (branchConfig.get(suite, 0), ) + SUITES[suite]['options']
>         else:
>             # Suites that are turned on by default
>-            BRANCHES[branch][suite + '_tests'] = (talosConfig.get(suite, 1), ) + SUITES[suite]['options']
>+            BRANCHES[branch][suite + '_tests'] = (branchConfig.get(suite, 1), ) + SUITES[suite]['options']

This would stay as well, then.

>     'tracemonkey': {
>         'repo_path': 'tracemonkey',
>         'mozconfig_dir': 'tracemonkey',
>         'branch_name': 'TraceMonkey',
>         'mobile_branch_name': 'TraceMonkey',
>         'build_branch': 'TraceMonkey',
>         'start_hour': [3],
>@@ -158,28 +133,16 @@ PROJECT_BRANCHES = {
>                 'enable_valgrind_checktests': True,
>             },
>             'linux64-debug': {
>                 'enable_valgrind_checktests': True,
>             },
>         },
>         'create_snippet': True,
>         'create_partial': True,
>-        'talos_suites': {
>-            'remote-ts': 1,
>-            'remote-tdhtml': 1,
>-            'remote-tsvg': 1,
>-            'remote-tsspider': 1,
>-            'remote-tpan': 1,
>-            'remote-tp4m': 1,
>-            'remote-tp4m_nochrome': 1,
>-            'remote-twinopen': 1,
>-            'remote-tzoom': 1,
>-            'v8': 1,
>-        }
>     },

This would turn off v8 on tracemonkey, which may or may not be something we want right now.
Let's leave it til we decide in bug 675283 or followup bugs.

Comment 6

[Mike Taylor [:bear]]

Attachment: enable remote-* talos tests by default

Comment 7

[Mike Taylor [:bear]]

Attachment: enable remote-* talos tests by default

Comment 8

[Mike Taylor [:bear]]

Comment on attachment 550171 [details] [diff] [review]
enable remote-* talos tests by default

committed changeset 4519:9b1757bb4d48

Comment 9

[Mike Taylor [:bear]]

in production

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

This guy missed the merge from default from production, possibly because it needed to be pulled into the repo first. See http://hg.mozilla.org/build/buildbot-configs/graph.

Comment 11

[Aki Sasaki (not active)]

Picked up on Thursday's reconfig.