676039 - show_bug.cgi ctype=xml should include attachment authors full name

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Frank Becker]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7) AppleWebKit/534.48.3 (KHTML, like Gecko) Version/5.1 Safari/534.48.3

Steps to reproduce:

In Mylyn we want to fix bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=353195 and we need the full name of the attachment author


Actual results:

only the attachment author email is included


Expected results:

the full name of the  attachment author should be in the output xml

Comment 1

[Frank Becker]

Attachment: patch V1

Comment 2

[Max Kanat-Alexander]

Comment on attachment 550141 [details] [diff] [review]
patch V1

This seems like a slippery slope. Why do you need this information for attachers but not for reporters, assignees, and ccs?

Comment 3

[Frank Becker]

(In reply to comment #2)
> Comment on attachment 550141 [details] [diff] [review] [diff] [details] [review]
> patch V1
> 
> This seems like a slippery slope. Why do you need this information for
> attachers but not for reporters, assignees, and ccs?

I think we need the reporters, assignees, and ccs but actual we only have bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=353195

I create an new patch soon.

Comment 4

[Max Kanat-Alexander]

I see. I don't want to add this information to the bug XML; it seems like it's something that should be known per-user instead of per-bug. The WebService allows you to get this information for users, perhaps you should get it that way?

Comment 5

[Frank Becker]

The Reporter and assigned_to have the Email address and the Full name

In Mylyn we Need a way to get the information witout using the webservice because the webservice is optional and Not setup inmost of the instances.

For the cc i Found nö way how to get the cc full name.

Comment 6

[Steffen Pingel]

From my experience, very few (public) servers have XML-RPC enabled. Having this information available somewhere in the XML would be nice.

Comment 7

[Frank Becker]

Attachment: patch V2

Now the attacher is handled in the same way as reporter, assigned_to, qa_contact.

Comment 8

[Gervase Markham [:gerv]]

Comment on attachment 613124 [details] [diff] [review]
patch V2

r=gerv.

Gerv

Comment 9

[Frédéric Buclin]

Comment on attachment 613124 [details] [diff] [review]
patch V2

You also have to fix pages/bugzilla.dtd.tmpl to take this change into account.

Comment 10

[Frank Becker]

Attachment: patch V3

bugzilla.dtd.tmpl is now changed!

Comment 11

[Frédéric Buclin]

Comment on attachment 623756 [details] [diff] [review]
patch V3

>=== modified file 'template/en/default/bug/show.xml.tmpl'

>+            <attacher [% IF a.attacher.name != '' %] name="[% a.attacher.name FILTER xml %]"[% END -%]>

Remove the whitespace before [% IF ... %], else two whitespaces are printed.



>=== modified file 'template/en/default/pages/bugzilla.dtd.tmpl'

>+<!ATTLIST attacher
>+          name CDATA #REQUIRED
>+          >

Fix the indentation of >.


Both comments can be fixed on checkin. r=LpSolit

Comment 12

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/bug/show.xml.tmpl
modified template/en/default/pages/bugzilla.dtd.tmpl
Committed revision 8238.