676045 - Add "number of forks" filter to Search

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Sean McArthur [:seanmonstar]]

Add a slider that will allow the user to filter out results that have less than the desired number of forks(copies) from the search results.

Comment 1

[Sean McArthur [:seanmonstar]]

Attachment: First run at copies slider

This is my shot at the slider. If it's ugly, or too big, or whatever, let me know.

Comment 2

[Wil Clouser [:clouserw]]

Crystal, can you give us a recommendation on getting this slider to fit in a little better?  It's not super high traffic so don't need anything detailed.

Comment 3

[Daniel Buchner [:dbuc]]

I can style this sucker to match our theme, just let me know when you drop it on master sean.

Comment 4

[Sean McArthur [:seanmonstar]]

@dbuc: It might not get to master until we freeze, since it depends on another library.

However, it is completely self-contained here: http://jsfiddle.net/seanmonstar/h3hxJ/

Comment 5

[Daniel Buchner [:dbuc]]

I'll have this styled up lickity split!

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Sean McArthur [:seanmonstar] from comment #4)
> @dbuc: It might not get to master until we freeze, since it depends on
> another library.
> 
> However, it is completely self-contained here:
> http://jsfiddle.net/seanmonstar/h3hxJ/

For whatever it's worth, trying to play with that slider made NoScript throw up a warning about clickjacking. Not sure if it's just that "Result" text being overlayed or if it's more inherent to the slider itself...

"NoScript intercepted a mouse or keyboard interaction with a partially hidden element. Click on the image below to cycle between the obstructed and the clear version."

Comment 7

[Daniel Buchner [:dbuc]]

Here's what I'm thinking on slider styling: http://jsfiddle.net/h3hxJ/8/

Comment 8

[Sean McArthur [:seanmonstar]]

this has landed in master https://github.com/mozilla/FlightDeck/commit/16fcaf219c234924e7f35424dfee095be0f43ee7

Comment 9

[Daniel Buchner [:dbuc]]

In reviewing the current iteration of the slider on master, I would like to see us modify the follow three things:

1. Change the label to read: "X copy/ies or greater"
2. Show the available upper and lower bounds to the bottom left and bottom right of the slider so users know they are on X step out of a max Y
3. Do change the slider on every step in the bounds, even if a step does not alter the resulting returned set.

Comment 10

[Sean McArthur [:seanmonstar]]

all 3 of those are in this commit, now on master https://github.com/mozilla/FlightDeck/commit/3ed2ca7e9cfa2a07ff890210b569f7000986cb9b

Comment 11

[Sean McArthur [:seanmonstar]]

this is live!

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://builder.addons.mozilla.org/search/?q=test&copies=1.