gingerbread theme for android 2.3.5

VERIFIED FIXED in Firefox 6

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
4 years ago

People

(Reporter: microrffr, Assigned: mfinkle)

Tracking

Trunk
Firefox 6
ARM
Android

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110622131247

Steps to reproduce:

Re: Bug 649820
After upgrading android from 2.3.4 -> 2.3.5, theme has reverted to classic.
See /mobile/themes/core/jar.mn:124


Actual results:

classic theme


Expected results:

gingerbread theme
http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/jar.mn#134

Needs an osversion=2.3.5, or would be better to change those to a 2.3.*

Updated

6 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

6 years ago
tracking-fennec: --- → ?

Updated

6 years ago
OS: Linux → Android
Hardware: x86_64 → ARM
osversion=2.3.* does not do what you hope it would. '*' is seen as infinity, not as "match anything".

Bug 380401 tired to add a cleaner way to sandwich version tests between a lower (froyo) and a higher (honeycomb) range. We'll need the "range-based selection" mentioned in comment 12.

For now, adding a few dummy versions (*cough*hack*cough*) along with 2.3.5 would at least protect us against any new Gingerbread releases.
Created attachment 550299 [details] [diff] [review]
hack (I mean patch)

Patch adds some versions to the gingerbread theme. Sadly, we should consider moving this to aurora and beta.
Assignee: nobody → mark.finkle
Attachment #550299 - Flags: review?(mbrubeck)
Comment on attachment 550299 [details] [diff] [review]
hack (I mean patch)

Told you so.*

*bug 653134 comment 15 :)
Attachment #550299 - Flags: review?(mbrubeck) → review+

Comment 5

6 years ago
+% skin browser classic/1.0 %skin/gingerbread/ os=Android osversion=2.3 osversion=2.3.3 osversion=2.3.4 osversion=2.3.5 osversion=2.3.6 osversion=2.3.7

Eww.  so this will break if Gingerbread upgrades past 2.3.7?
http://hg.mozilla.org/integration/mozilla-inbound/rev/07a247973487
(In reply to comment #5)

> Eww.  so this will break if Gingerbread upgrades past 2.3.7?

Yes, but bug 676183 will save us before then, I hope
http://hg.mozilla.org/mozilla-central/rev/07a247973487
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Comment on attachment 550299 [details] [diff] [review]
hack (I mean patch)

Requesting approval-mozilla-aurora and approval-mozilla-beta.  This mobile-only change prevents new versions of Android from regressing Fennec's theme, by adding a few numbers to a hard-coded list of Android versions.

I know this is very late for Firefox 6, but this is an extremely low-risk change that fixes a very visible regression of a new feature in Firefox 6.
Attachment #550299 - Flags: approval-mozilla-beta?
Attachment #550299 - Flags: approval-mozilla-aurora?
microrffr@gmail.com, just want to confirm if what you are running is the Nexus S 4G model?
Comment on attachment 550299 [details] [diff] [review]
hack (I mean patch)

Android only change that only affects the default theme used based on Android version number. Getting this on beta is important since the newer versions of Android are turning up in the field now.
Attachment #550299 - Flags: approval-mozilla-beta?
Attachment #550299 - Flags: approval-mozilla-beta+
Attachment #550299 - Flags: approval-mozilla-aurora?
Attachment #550299 - Flags: approval-mozilla-aurora+
Landed on Beta (Firefox 6) and Aurora (Firefox 7):

http://hg.mozilla.org/releases/mozilla-beta/rev/7062bb1f249d
http://hg.mozilla.org/releases/mozilla-aurora/rev/17d82fcd27ad
status-firefox5: --- → unaffected
status-firefox6: --- → fixed
status-firefox7: --- → fixed
status-firefox8: --- → fixed
Target Milestone: --- → Firefox 6
(Reporter)

Comment 13

6 years ago
:aaronmt, I'm using a Samsung Fascinate.
(Reporter)

Updated

6 years ago
Status: RESOLVED → VERIFIED
(In reply to comment #13)
> :aaronmt, I'm using a Samsung Fascinate.

Hi, you marked this bug as verified fixed, can you just confirm which build you see this fixed on now?
(Reporter)

Comment 15

6 years ago
It's working on 2011/08/05 nightly right now.
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.