676129 - Update refresh_nodes to the latest node-assignment schema

Status: VERIFIED FIXED

(Cloud Services :: Server: Other, defect)

Description

[Toby Elliott [:telliott]]

Attachment: refreshes nodes

refresh_nodes now needs to take a numerical value for the refresh and can now work on a product, cluster or node level as needed.

Comment 1

[:Atoll]

Comment on attachment 550243 [details]
refreshes nodes

>storage.set_value('available', count, product, cluster, node)

Should only set_value if current available is less than the value to be set.

Comment 2

[Toby Elliott [:telliott]]

Attachment: Script (and support) to update available nodes

Well, that actually complicated things a bit. Full patch to make this happen attached.

Comment 3

[Rob Miller [:rmiller]]

Comment on attachment 550742 [details] [diff] [review]
Script (and support) to update available nodes

Review of attachment 550742 [details] [diff] [review]:
-----------------------------------------------------------------

::: nodes/storage.py
@@ +95,5 @@
> +
> +        if node is not None:
> +            where.append(nodes.c.node == node)
> +
> +        return where

This is definitely a use where SQLAlchemy's expression syntax is better than static SQL.  :)

Comment 4

[Toby Elliott [:telliott]]

fixed in http://hg.mozilla.org/services/server-node-assignment/rev/4ae7541ff6c1