676135 - Webifyme: Object descriptions to not match objects

Status: RESOLVED FIXED

(Websites :: webifyme.org, defect, P1)

Description

[Chris More [:cmore]]

Attachment: Action Figures Screenshot

When viewing the following collages we noticed an issue that can be seen in the attached screenshot.

https://webifyme-dev.allizom.org/en-US/collage/d116c3ea8ccf/

It appears that the description of some objects do not match the object itself. For example, the action figure displays the description for the noisemaker. The noisemaker object displays the description of the stamp.

Here are the details for this example:

The description of the noisemaker are displayed for 

object ID 45:

https://github.com/mozilla/webifyme/blob/master/ff4/things/questions_answers.py#L396

and object 127:

https://github.com/mozilla/webifyme/blob/master/ff4/things/questions_answers.py#L724

and object 140:

https://github.com/mozilla/webifyme/blob/master/ff4/things/questions_answers.py#L776

and object 192:

https://github.com/mozilla/webifyme/blob/master/ff4/things/questions_answers.py#L984

Then look in the images mapping here:

https://github.com/mozilla/webifyme/blob/master/ff4/things/fixtures/images.yaml

Object 127 and 140 are not defined, but...

object 45: https://github.com/mozilla/webifyme/blob/master/ff4/things/fixtures/images.yaml#L244 is an action figure.

and object 192: https://github.com/mozilla/webifyme/blob/master/ff4/things/fixtures/images.yaml#L496 is the reddit button.

I initially thought that maybe we were looking at this wrong and this is not how it works, but I was able to find occurrences where the mapping is working correctly and the right descriptions are showing. 

Here is an example of when the mapping is right:

https://github.com/mozilla/webifyme/blob/master/ff4/things/questions_answers.py#L276

object ID 15 is mapped to the correct image in the images.yaml file: https://github.com/mozilla/webifyme/blob/master/ff4/things/fixtures/images.yaml#L272

also

object ID 63 is mapped to the correct image in the images.yaml file: https://github.com/mozilla/webifyme/blob/master/ff4/things/fixtures/images.yaml#L12

Spot checking a number of object and possible object descriptions have revealed a number of incorrect mappings or at least ones that do not make sense.

We need TBG to:

1) review each of the object descriptions in https://github.com/mozilla/webifyme/blob/master/ff4/things/questions_answers.py#L468 from line 217 to 1212

2) Look at the [ID]: number and cross reference it with pk: [ID] number in https://github.com/mozilla/webifyme/blob/master/ff4/things/fixtures/images.yaml 

3) Verify that the image that is being displayed correlates to the description being shown.

Comment 1

[Chris More [:cmore]]

Note: please do not make string changes to https://github.com/mozilla/webifyme/blob/master/ff4/things/questions_answers.py. We are not in the second string freeze because our localizers are preparing French, German, and Spanish translations. The ID mappings can be adjusted, but the description themselves must remain exactly the same as they are now.

Comment 2

[William Reynolds [:williamr]]

(In reply to comment #1)
> We are not in the second string freeze because our localizers are
> preparing French, German, and Spanish translations.

Correction: We *are* in a string freeze right now - that's why we should not be making any string changes for this bug.

Comment 3

[[:brez]]

Did this start recently?  i.e. after the recent change to remove text from the database?

Comment 4

[Chris More [:cmore]]

Brez: yeah, i think when the text was removed from the database and into python that the mappings got messed up. We were pretty sure this was historically working and we would have noticed it before. It is more of a context bug then a real programming bug so it wouldn't have been instantly spotted.

Comment 5

[[:brez]]

Cool - yea im looking into this right now

Comment 6

[[:brez]]

Basically some answers are found in multiple questions, which is causing this weirdness - I'm going to key on the image name itself (not the ID) to fix this problem, reduce the redundancy in ANSWERS_BY_IMAGE and generally make things a lot clearer.

Comment 7

[[:brez]]

Won't be any text changes, for the record..

Comment 8

[Chris More [:cmore]]

Good idea on to key the image name, because at least that is something real that the front-end uses. Keep us posted.

Comment 9

[[:brez]]

Ok its all set:

https://github.com/mozilla/webifyme/commit/729de8619abc408ad8f08bc7086e8decd447cb5d