Last Comment Bug 676188 - Misc misuses of PRBool caught by the compiler while attempting typedef bool PRBool
: Misc misuses of PRBool caught by the compiler while attempting typedef bool P...
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Michael Wu [:mwu]
:
Mentors:
Depends on:
Blocks: 675553
  Show dependency treegraph
 
Reported: 2011-08-02 22:58 PDT by Michael Wu [:mwu]
Modified: 2011-08-31 02:04 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (7.16 KB, patch)
2011-08-02 22:58 PDT, Michael Wu [:mwu]
jmathies: review+
jst: review+
bzbarsky: review+
dougt: review+
bzbarsky: review+
mak77: review+
Details | Diff | Review

Description Michael Wu [:mwu] 2011-08-02 22:58:20 PDT
Created attachment 550310 [details] [diff] [review]
Fix

Compilers catch the remaining problems that boolcheck doesn't when we do typedef bool PRBool.

Reviewers:

jimm:
 browser/components/shell/src/nsWindowsShellService.cpp               |    4 +-
 toolkit/components/parentalcontrols/nsParentalControlsServiceWin.cpp |   17 +++++++---

dwitte:
 extensions/cookie/nsCookiePermission.cpp                             |   10 +++--
 extensions/cookie/nsCookiePromptService.cpp                          |    2 -

roc:
 layout/tables/nsTableRowFrame.h                                      |    4 +-

dougt:
 modules/libreg/include/VerReg.h                                      |    2 -

bz:
 netwerk/base/src/nsAutodialWin.cpp                                   |    4 +-
 netwerk/base/src/nsStandardURL.h                                     |    2 -
 parser/htmlparser/src/CNavDTD.cpp                                    |    2 -

mak:
 toolkit/components/places/nsNavHistory.cpp                           |    2 -
Comment 1 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-08-02 23:05:33 PDT
Comment on attachment 550310 [details] [diff] [review]
Fix

For the CNavDTD code, I'd ask for an enum for the tristate, but that's all dead code anyway.

r=me on the netwerk and parser bits.
Comment 2 Michael Wu [:mwu] 2011-08-30 08:57:24 PDT
Comment on attachment 550310 [details] [diff] [review]
Fix

dwitte -> jst on cookie changes.
Comment 4 Marco Bonardo [::mak] 2011-08-31 02:04:41 PDT
http://hg.mozilla.org/mozilla-central/rev/a513e2816eaf

Note You need to log in before you can comment on or make changes to this bug.