676188 - Misc misuses of PRBool caught by the compiler while attempting typedef bool PRBool

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Michael Wu [:mwu]]

Attachment: Fix

Compilers catch the remaining problems that boolcheck doesn't when we do typedef bool PRBool.

Reviewers:

jimm:
 browser/components/shell/src/nsWindowsShellService.cpp               |    4 +-
 toolkit/components/parentalcontrols/nsParentalControlsServiceWin.cpp |   17 +++++++---

dwitte:
 extensions/cookie/nsCookiePermission.cpp                             |   10 +++--
 extensions/cookie/nsCookiePromptService.cpp                          |    2 -

roc:
 layout/tables/nsTableRowFrame.h                                      |    4 +-

dougt:
 modules/libreg/include/VerReg.h                                      |    2 -

bz:
 netwerk/base/src/nsAutodialWin.cpp                                   |    4 +-
 netwerk/base/src/nsStandardURL.h                                     |    2 -
 parser/htmlparser/src/CNavDTD.cpp                                    |    2 -

mak:
 toolkit/components/places/nsNavHistory.cpp                           |    2 -

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 550310 [details] [diff] [review]
Fix

For the CNavDTD code, I'd ask for an enum for the tristate, but that's all dead code anyway.

r=me on the netwerk and parser bits.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 550310 [details] [diff] [review]
Fix

dwitte -> jst on cookie changes.

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a513e2816eaf

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/a513e2816eaf