676192 - Remove kHashEnumerateRemove and make nsHashtableEnumFunc return PRBool

Status: RESOLVED FIXED

Description

[Michael Wu [:mwu]]

Created attachment 550315 [details] [diff] [review]
Fix

As it turns out, most users of nsHashtable's Enumerate/Reset functions pass a callback that returns PRBool, not PRIntn. It looks like users typically use Reset() to delete entries instead of Enumerate so there is little need to pass anything other than true/false. There was only one user which actually used PRIntn/kHashEnumerateRemove, and I've converted that user to nsClassHashtable in bug 675873.

Comment 1

[Benjamin Smedberg [:bsmedberg]]

Comment on attachment 550315 [details] [diff] [review]
Fix

Can we just remove nsHashtable?

Comment 2

[Michael Wu [:mwu]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> Comment on attachment 550315 [details] [diff] [review]
> Fix
> 
> Can we just remove nsHashtable?

There's enough users that it's hard to do manually, but maybe automated rewrites can help.

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09a0af24837d

Comment 4

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/09a0af24837d