Remove kHashEnumerateRemove and make nsHashtableEnumFunc return PRBool
RESOLVED
FIXED
in mozilla9
Status
()
People
(Reporter: mwu, Assigned: mwu)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
3.16 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Created attachment 550315 [details] [diff] [review] Fix As it turns out, most users of nsHashtable's Enumerate/Reset functions pass a callback that returns PRBool, not PRIntn. It looks like users typically use Reset() to delete entries instead of Enumerate so there is little need to pass anything other than true/false. There was only one user which actually used PRIntn/kHashEnumerateRemove, and I've converted that user to nsClassHashtable in bug 675873.
Attachment #550315 -
Flags: review?(benjamin)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 550315 [details] [diff] [review] Fix Can we just remove nsHashtable?
Attachment #550315 -
Flags: review?(benjamin) → review+
|
(Assignee) | |
Comment 2•7 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #1) > Comment on attachment 550315 [details] [diff] [review] > Fix > > Can we just remove nsHashtable? There's enough users that it's hard to do manually, but maybe automated rewrites can help.
|
|
(Assignee) | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/09a0af24837d
Whiteboard: [inbound]
|
||
Comment 4•7 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/09a0af24837d
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•