Closed Bug 676192 Opened 10 years ago Closed 10 years ago
Hash Enumerate Remove and make ns Hashtable Enum Func return PRBool
As it turns out, most users of nsHashtable's Enumerate/Reset functions pass a callback that returns PRBool, not PRIntn. It looks like users typically use Reset() to delete entries instead of Enumerate so there is little need to pass anything other than true/false. There was only one user which actually used PRIntn/kHashEnumerateRemove, and I've converted that user to nsClassHashtable in bug 675873.
Attachment #550315 - Flags: review?(benjamin)
Comment on attachment 550315 [details] [diff] [review] Fix Can we just remove nsHashtable?
Attachment #550315 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg [:bsmedberg] from comment #1) > Comment on attachment 550315 [details] [diff] [review] > Fix > > Can we just remove nsHashtable? There's enough users that it's hard to do manually, but maybe automated rewrites can help.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.