Closed
Bug 676192
Opened 14 years ago
Closed 14 years ago
Remove kHashEnumerateRemove and make nsHashtableEnumFunc return PRBool
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: mwu, Assigned: mwu)
References
Details
Attachments
(1 file)
|
3.16 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
As it turns out, most users of nsHashtable's Enumerate/Reset functions pass a callback that returns PRBool, not PRIntn. It looks like users typically use Reset() to delete entries instead of Enumerate so there is little need to pass anything other than true/false. There was only one user which actually used PRIntn/kHashEnumerateRemove, and I've converted that user to nsClassHashtable in bug 675873.
Attachment #550315 -
Flags: review?(benjamin)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 550315 [details] [diff] [review]
Fix
Can we just remove nsHashtable?
Attachment #550315 -
Flags: review?(benjamin) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #1)
> Comment on attachment 550315 [details] [diff] [review]
> Fix
>
> Can we just remove nsHashtable?
There's enough users that it's hard to do manually, but maybe automated rewrites can help.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•