676247 - Disable places consistency checks as we don't use places

Status: RESOLVED WONTFIX

(MailNews Core :: Database, defect)

Description

[Ludovic Hirlimann [:Usul]]

I just caught the following in the Error console :

[ Places Maintenance ]
> Integrity check
+ The database is sane
> Coherence check
+ The database is coherent

AFAIK we don't use places, so would be nice not to check the db.

Comment 1

[rsx11m]

Also see bug 672988 on unused places.sqlite file occupying 10MB in the profile.

Comment 2

[:aceman]

Hi, why do you think TB does not use Places? I thought that too, but then came across bug 677954.
Has something changed?

Comment 3

[Wayne Mery (:wsmwk)]

(assuming this perf issue isn't debilitating, or perhaps even noticeable)

Comment 4

[Wayne Mery (:wsmwk)]

ludo?

(In reply to :aceman from comment #2)
> Hi, why do you think TB does not use Places?

Comment 5

[Ludovic Hirlimann [:Usul]]

(In reply to Wayne Mery (:wsmwk) from comment #4)
> ludo?
> 
> (In reply to :aceman from comment #2)
> > Hi, why do you think TB does not use Places?

We don't browse and places is to store url and the file never grows - so I don't think we use it.

Comment 6

[:aceman]

It looks like we browse, see bug 677954.

The file probably grows only when you reach those 10MB of history entries.

Comment 7

[rsx11m]

(In reply to :aceman from comment #6)
> It looks like we browse, see bug 677954.

That one looked more like a toolkit bug, which is fixed by now:

(Quoting Mark Banner (:standard8) from bug 677954 comment #7)
> We use some of the interfaces, at most, we could be storing favicon
> information. However, places is disabled by default, so it shouldn't be
> storing history. [...]
> It is slightly surprising that places is allocating memory and doing stuff
> with the db when the places history is disabled.

(Quoting Jonathan Protzenko [:protz] from bug 677954 comment #12)
> We should just revert that change, it's useless now bug 674210 has landed.

If places is disabled in Thunderbird then places.sqlite should be redundant, but given that extensions like Thunderbrowse may keep track of browsing and bookmarks/history, any fix here (and for bug 672988) will have to consider that something may actually want to use it even if it's not Thunderbird itself.

Comment 8

[Wayne Mery (:wsmwk)]

based on previous comments, places does get used. so => wontfix