676329 - restore the saving of manually added contacts

Status: RESOLVED WONTFIX

(Mozilla Labs :: F1, defect)

Description

[Shane Caraveo (:mixedpuppy)]

The following change removed functionality that needs to come back somehow.

https://github.com/mozilla/fx-share-addon/commit/aa0feb5859a6186865d5434c743669ac226a243f#diff-4

If a user enters a contact not in autocomplete, and the send is successful, we need to store that contact for future autocompletion.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Shouldn't this be the responsibility of the app rather than the mediator?  But if the mediator really does want to store this "per-app" data, I guess we'd need a UI to manage the stored entries?  (If the app was responsible, then presumably it would just fall back on its existing contacts UI for managing them...)

Comment 2

[Shane Caraveo (:mixedpuppy)]

with the ui in the mediator, the mediator has to handle it.  the storage mechanism could be a part of the app (mediator passes manually added addresses to the app).

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #2)
> with the ui in the mediator, the mediator has to handle it.

I don't see why that is the case - couldn't the app notice the "to" field and update its list so the next time the auto-complete list is requested from that app it includes the new name.

> the storage
> mechanism could be a part of the app (mediator passes manually added
> addresses to the app).

The mediator does now - as part of the message.  The app might choose to use its own back-end storage - eg, gmail may choose to add such addresses to "contacts".

Also, storing auto-complete entries locally implies a UI for managing them (eg, to remove such addresses)