Change webapp navigation to reflect new version options

VERIFIED FIXED in 2.2

Status

Socorro
General
P1
blocker
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: laura, Assigned: brandon)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Right now the version dropdown is pre-filled with version values.  This needs to change to reflect the new aggregation criteria, so each beta will have its own link, which should be named as e.g. 6.0b1, 6.0b2, etc.

You should be able to get this information from the productdims table, although I'm not dead sure exactly what jberkus has implemented in the end - please check in with he and rhelmer.

If you can, putting this in middleware would be a Good Thing to do too.  Right now it's just more SQL in the webapp.  Consult lonnen for advice and assistance if needed.
Laura,

I'm not changing productdims, since that would break too much old functionality.

Instead, I've created a new view (stored query) called product_selector which has all "current" versions, from both the old and new interfaces.
product_selector looks like it has everything we need, I'll create a middleware service to return it as JSON that the web app can call.
Depends on: 676612
(Assignee)

Comment 3

6 years ago
Currently we have four featured versions, with a selection of other versions available to view. Is this the paradigm you want used in this bug? The way those featured and unfeatured versions are generated affects a large part of the application so I want to be sure I do not introduce follow-on bugs as a result of this work.
(Reporter)

Comment 4

6 years ago
Yes, nothing should change from the users' perspective except the data in the version dropdown.
(Assignee)

Comment 5

6 years ago
Created attachment 551576 [details] [diff] [review]
Changing to new product_info table

This patch switches all productdims references for the navigation to product_info view.
Attachment #551576 - Flags: review?(chris.lonnen)
(Assignee)

Comment 6

6 years ago
Created attachment 551636 [details] [diff] [review]
More complete patch

This patch is more complete than the last one and includes the middleware changes.
Attachment #551576 - Attachment is obsolete: true
Attachment #551576 - Flags: review?(chris.lonnen)
Attachment #551636 - Flags: review?(chris.lonnen)

Comment 7

6 years ago
Comment on attachment 551636 [details] [diff] [review]
More complete patch

Review of attachment 551636 [details] [diff] [review]:
-----------------------------------------------------------------

This breaks the admin panel. Unfortunately it doesn't log the error. Also, your changes to the services layer likely belong in a different bug.
Attachment #551636 - Flags: review?(chris.lonnen) → review-
For QA/dev: this is probably the reason we're seeing:

[09:10:36.839] GET https://crash-stats-dev.allizom.org/topcrasher/byversion/Firefox/5.01 [HTTP/1.1 500 Internal Server Error 2225ms]
(Assignee)

Comment 9

6 years ago
Created attachment 551795 [details] [diff] [review]
Cleaner patch
Attachment #551636 - Attachment is obsolete: true
Comment on attachment 551795 [details] [diff] [review]
Cleaner patch

Review of attachment 551795 [details] [diff] [review]:
-----------------------------------------------------------------

This breaks the admin panel a bit, but I think it will have to. This is an r+ if you file a separate bug for that issue, or you can edit this bug to creep the scope.
Attachment #551795 - Flags: review?
(Assignee)

Updated

6 years ago
Blocks: 677585

Updated

6 years ago
Attachment #551795 - Flags: review? → review+
(Assignee)

Comment 11

6 years ago
Committed revision 3349.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
QA verified - the 500 error in comment 8 no longer occurs (200 OK). Web app navigation has also properly updates with the new version options.
Status: RESOLVED → VERIFIED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.