676421 - Templates not ready for localization may appear to be and get counted in total, while not appearing on dashboard

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Ton [:Tonnes]]

Apparently, templates and possibly other articles that have a status of not allowing translations but do have a Current status get counted in the total number of templates. This results in an incomplete list of localized templates, while the missing ones do not appear on the list of untranslated templates. The latter should be fine, but the total number of templates should not match the en-US ones.

An example of such a template at this point is https://support.mozilla.com/en-US/kb/templateimporthtmlbookmarks/history .

Note that the article itself has Allow translations checked when editing (including a Translate button), while it does not appear to be ready fpr localization in the history list, and neither on the localized page (user gets warned), in case this is related.

Comment 1

[Erik Rose [:erik][:erikrose]]

QA: I also fixed an identical bug with the "All Articles" row, so please check that as well.

STR:
1. Make an article that has its "Allow Translations" checkbox checked, has at least one approved revision, but has none marked as Ready For Localization. It should not contribute to the totals in either Templates or All Articles.
2. Mark it ready for localization. Now it should.

Comment 2

[Erik Rose [:erik][:erikrose]]

(Clarification: try the above with both a template and a normal doc.)

Landed in http://github.com/jsocol/kitsune/commit/ca252304064638bb574c9e1a89d325140181bee9.

Comment 3

[Rebecca Billings [:rbillings]]

Verified articles and templates only get counted once they have been approved and also marked ready for localization.