676424 - Thank you note for contributions is not being sent

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Pick an add-on which has Thank you email for contributions set up (https://addons.allizom.org/en-US/firefox/addon/bug-00000)
2. Make a contribution
3. Wait for the thank you note


actual behavior:
I never got the Thank you note.

Comment 1

[Gregory Koberger (:gkoberger)]

Additional information: Krupa is using a different email address on PayPal and AMO.  I didn't realize we sent the email to the paypal address (which makes sense; oversight on my part), just need to change how we send emails if the email address isn't in the database.

Comment 2

[krupa raj[:krupa]]

(In reply to comment #1)
> Additional information: Krupa is using a different email address on PayPal
> and AMO.  I didn't realize we sent the email to the paypal address (which
> makes sense; oversight on my part), just need to change how we send emails
> if the email address isn't in the database.

I tried using an account which had the same email id as my paypal account. I didn't get any emails even then.

Comment 3

[Gregory Koberger (:gkoberger)]

Okay, I spent some time on this and I don't think it matters if the address is in the database or not.  However, I can't figure out how to actually play around with it locally, since it uses PayPal api calls.  Andy, any tips on doing paypal debugging locally?  I've spent an hour or so on it, and can't figure out the best way to do this.

Comment 4

[Andy McKay]

The email gets sent when Paypal sends in an IPN request. The tests for that are here and do all the fakery to pretend there's a Paypal request:

https://github.com/jbalogh/zamboni/blob/master/apps/amo/tests/test_views.py#L341

But it looks like those tests don't check that an email is being sent. So that should be added.

Once you are happy that's good, I would try sending a test IPN ping from Paypal sandbox over to preview (assuming your own zamboni instance is not accessible external). After logging into https://developer.paypal.com, hit Simulate Instant Payment Notification. I put a username and password in your root directory on khan.

Comment 5

[Gregory Koberger (:gkoberger)]

Andy: Okay, I spent some time on this.  Locally, the problem seems to be this:
https://github.com/gkoberger/zamboni/blob/master/apps/amo/views.py#L252

(Pdb) urllib2.urlopen(settings.PAYPAL_CGI_URL, data, 20)
*** Exception: 
(Pdb) settings.PAYPAL_CGI_URL
'https://www.paypal.com/cgi-bin/webscr'
(Pdb) data
u'cmd=_notify-validate&'

So, the email isn't sending because it never gets past this line (at least locally).  Why are the tests trying to access an external URI?  Why don't they fail when they can't?  

The emails not sending are a side effect of a bigger problem -- the "c.mail_thanks()" code is never getting hit.  Any insights?  This paypal stuff is all greek to me, and I have no clue what's going on.

Comment 6

[Andy McKay]

http://github.com/jbalogh/zamboni/commit/009276

Comment 7

[krupa raj[:krupa]]

verified fixed. I just got the thank you note.

Comment 8

[krupa raj[:krupa]]

Attachment: post-fix screenshot