Last Comment Bug 676450 - Lots of mistakes in printf format in nsGtkIMModule.cpp
: Lots of mistakes in printf format in nsGtkIMModule.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Gtk (show other bugs)
: unspecified
: All Linux
: -- normal (vote)
: mozilla8
Assigned To: Hiroyuki Ikezoe (:hiro)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-03 18:36 PDT by Hiroyuki Ikezoe (:hiro)
Modified: 2011-08-09 11:54 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (4.82 KB, patch)
2011-08-03 18:36 PDT, Hiroyuki Ikezoe (:hiro)
masayuki: review+
Details | Diff | Review

Description Hiroyuki Ikezoe (:hiro) 2011-08-03 18:36:20 PDT
Created attachment 550577 [details] [diff] [review]
Fix

First, I found a mistake in the following:

336 void
337 nsGtkIMModule::OnFocusWindow(nsWindow* aWindow)
338 {
339     if (NS_UNLIKELY(IsDestroyed())) {
340         return;
341     }
342 
343     PR_LOG(gGtkIMLog, PR_LOG_ALWAYS,
344         ("GtkIMModule(%p): OnFocusWindow, aWindow=%p, mLastFocusedWindow=%p",
345          this, aWindow));

So I've opened bug 676442, then found other mistakes in nsGtkIMModule.cpp.
Actually there are lots of mistakes in other files, I hope the others will be fixed after landing of the fix of bug 676442. This patch is just the beginning.
Comment 2 :Ehsan Akhgari (busy, don't ask for review please) 2011-08-09 11:54:35 PDT
http://hg.mozilla.org/mozilla-central/rev/439bd18e040a

Note You need to log in before you can comment on or make changes to this bug.