Lots of mistakes in printf format in nsGtkIMModule.cpp

RESOLVED FIXED in mozilla8

Status

()

Core
Widget: Gtk
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

unspecified
mozilla8
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 550577 [details] [diff] [review]
Fix

First, I found a mistake in the following:

336 void
337 nsGtkIMModule::OnFocusWindow(nsWindow* aWindow)
338 {
339     if (NS_UNLIKELY(IsDestroyed())) {
340         return;
341     }
342 
343     PR_LOG(gGtkIMLog, PR_LOG_ALWAYS,
344         ("GtkIMModule(%p): OnFocusWindow, aWindow=%p, mLastFocusedWindow=%p",
345          this, aWindow));

So I've opened bug 676442, then found other mistakes in nsGtkIMModule.cpp.
Actually there are lots of mistakes in other files, I hope the others will be fixed after landing of the fix of bug 676442. This patch is just the beginning.
(Assignee)

Updated

6 years ago
Attachment #550577 - Flags: review?(masayuki)
Attachment #550577 - Flags: review?(masayuki) → review+
(Assignee)

Updated

6 years ago
Assignee: nobody → hiikezoe
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/439bd18e040a
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/439bd18e040a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.