676508 - Fix misleading comment - hooks are run in the order in which they are seen

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Jonathan Watt [:jwatt]]

The comment in hgcustom/hghooks/example-hgrc is totally wrong and misleading. It may have been true at some point that hg hooks were run in alphabetical order, but that is definitely no longer the case. Hooks are run in the order in which they are seen during parsing of the hg config files. Not only is it not possible to reorder hooks in a given file purely by changing the names of the hooks, it's also not possible to stop hooks defined in the user's ~/.hgrc from running before the same type of hooks in the repo .hg/hgrc (since the former file is parsed before the latter).

Of course I'm assuming here that we haven't hacked the mercurial installs we have to make hooks run in alphabetical order, but I don't see anything in https://hg.mozilla.org/hgcustom/ to suggest that we have.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[(not currently active) Ted Mielczarek]

It was true in a previous version of hg, FWIW.

Comment 3

[Benjamin Smedberg]

Yeah, they changed the ordering system at some point, and we've been having problems with it ever since...

Comment 4

[Jonathan Watt [:jwatt]]

It's a two or so line patch to add support to hg for a config flag that would cause the hooks to be sorted before calling them. If that would be useful to us I'd be happy to propose that patch to the hg guys.

Comment 5

[Jonathan Watt [:jwatt]]

Benjamin, is that worth doing?

Comment 6

[Benjamin Smedberg]

I believe they have rejected that in the past, take a look through the mercurial list archives.

Comment 7

[Jonathan Watt [:jwatt]]

Ok, thanks.

Pushed https://hg.mozilla.org/hgcustom/hghooks/rev/a4b9d91337c5