Closed Bug 676509 Opened 10 years ago Closed 10 years ago

GCLI browser UI and chrome UI should be separate implementations

Categories

(DevTools :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jwalker, Assigned: jwalker)

Details

(Whiteboard: [best:1d, likely:1d, worst:2d])

Currently only one significant file is used by both, that that has many hacks to support both environments.
Nick, did you get anywhere with this? I'm going to take it on.
Assignee: nobody → jwalker
See https://github.com/joewalker/gcli/tree/bug676509-separate however there's too much code duplication for me to be happy with this path right now.
Unless anyone complains, I'm going to close this bug as WONTFIX because it's not important for release, and it doesn't seem as important now:

Arguments for doing this:
- A significant % (I previously guessed 50%+) of the code in inputter.js was specific to one environment or the other, and the code to distinguish environments isn't clear

New arguments against doing this:
- The chrome/content displays have become more similar recently - more shared code
- It doesn't give us new features
- As Nick has pointed out, there are ways to do this without duplicating code
Whiteboard: [minotaur][best:1d, likely:1d, worst:2d] → [best:1d, likely:1d, worst:2d]
Blocks: GCLI-FUTURE
No longer blocks: GCLI-JS
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
No longer blocks: GCLI-FUTURE
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.