676541 - [traceback] Uncaught PermissionDenied in gallery.views.delete_media

Status: RESOLVED WONTFIX

(support.mozilla.org :: Knowledge Base Software, task, P4)

Description

[James Socol [:jsocol, :james]]

We sometimes throw a PermissionDenied error in gallery.utils.check_media_permissions but gallery.views.delete_media doesn't catch and handle it. We end up with a 500 ISE instead of a nice 403.

http://arecibo1.dmz.sjc1.mozilla.com/view/6779/ (VPN-only)

Thanks, Arecibo (and Sentinel, which tripped this)!


  File "/data/www/support.allizom.org/kitsune/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/support.allizom.org/kitsune/apps/access/decorators.py", line 47, in _wrapped_view
    return view_fn(request, *args, **kwargs)

  File "/data/www/support.allizom.org/kitsune/apps/gallery/views.py", line 199, in delete_media
    check_media_permissions(media, request.user, 'delete')

  File "/data/www/support.allizom.org/kitsune/apps/gallery/utils.py", line 102, in check_media_permissions
    raise PermissionDenied

Comment 1

[James Socol [:jsocol, :james]]

Derp, wrong component :(

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Cleaning up 2011Q4