676569 - test-content-proxy.testProxy failure: functions are functions 2 ("[object Object]" doesn't match /\[object Function.*\]/)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

Sometime between July 21 and yesterday, August 3, test-content-proxy.testProxy started failing against Nightly with the message: functions are functions 2 ("[object Object]" doesn't match /\[object Function.*\]/).

--------------------------------------------------------------------------------
info: executing 'test-content-proxy.testProxy'
info: pass: `win` object is unwrapped
info: pass: `this` is the original object
info: pass: called only once
info: pass: event is wrapped
info: pass: event.target is the wrapped window
info: pass: a == b == "object"
info: pass: a == b == "input"
info: pass: String.prototype overload works
info: pass: toString can't be called with this being the proxy
info: pass: but it works if we bind this to the original string
info: pass: mozMatchesSelector works while being called from the node
info: pass: mozMatchesSelector works while being called from a function reference to document.documentElement.mozMatchesSelector.call
info: pass: Event should not be equal to its prototype
info: pass: Events are working fine
info: pass: Nested attribute to sandbox object should not be proxified
info: pass: Nested attribute to proxy should not be double proxified
info: pass: form[nodeName] is valid
info: pass: has access to localStorage
info: pass: localStorage appears to work
info: pass: localStorage really works
info: pass: localStorage really, really works
info: pass: custom JS attributes are not wrapped
info: pass: custom JS attributes are not wrapped
info: pass: <object> is typeof 'function'
info: pass: <object> is HTMLObjectElement
info: pass: <object> has a setAttribute method
info: pass: strings are strings
info: pass: objects are objects
info: pass: functions are functions 1
error: TEST FAILED: test-content-proxy.testProxy (failure)
error: fail: functions are functions 2 ("[object Object]" doesn't match /\[object Function.*\]/)
info: Traceback (most recent call last):
  File "resource://testpkgs-api-utils-tests/test-content-proxy.js", line 202, in onDOMReady
    test.assertMatches(win.Object.prototype.toString.call(f), /\[object Function.*\]/, "functions are functions 2");
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 139, in assertMatches
    this.fail(message);
  File "resource://testpkgs-api-utils-lib/unit-test.js", line 116, in fail
    console.trace();
--------------------------------------------------------------------------------

Comment 1

[Myk Melez [:myk] [@mykmelez]]

I narrowed down the regression range to between the July 28 and 29 Windows nightlies, i.e. between http://hg.mozilla.org/mozilla-central/rev/cef1817c3b13 and http://hg.mozilla.org/mozilla-central/rev/a627b24e684e.

At first glance, http://hg.mozilla.org/mozilla-central/rev/dbefaf7244f1 seems like a possible culprit.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Highlight this new behavior in test

This test was added to highlight the behavior of Object.prototype.toString and ensure that it behaves correctly. It still do but only with function coming from the same compartments.

Comment 3

[Alexandre Poirot [:ochameau]]

Fix test bustage landed:
https://github.com/mozilla/addon-sdk/commit/3353a42df3aa93113851bdbaa3c4b82614019cbe

Comment 4

[Myk Melez [:myk] [@mykmelez]]

This doesn't happen on the branch 1.1 is targeting (currently the beta branch), so we don't actually need to fix it for 1.1.