676621 - Toaster alert needs better Honeycomb styling

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110804 Firefox/8.0a1 Fennec/8.0a1

This toaster notification needs Gingerbread (2.3) styling.

http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/extensions.js#815

STR: Install an addon, see it using the older style

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We already made some changes to better support gingerbread

Comment 2

[Aaron Train [:aaronmt]]

Attachment: Nightly (08/04)

(In reply to comment #1)
> We already made some changes to better support gingerbread
Which bug?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> Created attachment 550791 [details]
> Nightly (08/04)
> 
> (In reply to comment #1)
> > We already made some changes to better support gingerbread
> Which bug?

None actually. HG blames shows no differences between old and new. So let's see what changes we want to make in this bug.

Comment 4

[Sriram Ramasubramanian [:sriram]]

What is the expected display here?
Any mock-ups available?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

CC'ing Ian for some mockup advice. I guess we need a separate bug for honeycomb now too.

Comment 6

[Ian Barlow (:ibarlow)]

Attachment: Gingerbread Toast

Here's a mockup for the toast notification. You can probably start with the basic dialog box styling and work from there. Note that the box is a little bigger too, and we're using slightly larger fonts (the styling of which you can probably pull from prefs or add-ons)

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

We discovered that the current style fits gingerbread well. We do, however need a honeycomb style.

Ian - over to you for a mockup/spec

Comment 8

[Ian Barlow (:ibarlow)]

Attachment: mockup

Comment 9

[Ian Barlow (:ibarlow)]

Attachment: specs

Comment 10

[Sriram Ramasubramanian [:sriram]]

Currently the toaster we use have two lines of text in them. Are we aligning them in a single line? Or dropping one of them?

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Keep the titles for now. Put them on separate lines. Use Ian's spec as much as you can. Make sure the case of "no title" works like the current spec.

Ian - can we get a new spec that takes the title into account?

We can file a separate bug for auditing the current toaster text (for all cases) and make sure dropping the title doesn't leave us with too little context in the message.

Comment 12

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

The patch works fine for toasters with/without images and with/without titles.

Comment 13

[Sriram Ramasubramanian [:sriram]]

This patch works fine after this fix: https://bugzilla.mozilla.org/show_bug.cgi?id=658319

Comment 14

[Matt Brubeck (:mbrubeck)]

Patch needs some de-bitrotting.  I'll do this and then push to inbound.

Comment 15

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/0f1de3b4f9a5

Comment 17

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/0f1de3b4f9a5

Comment 18

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20111106
Firefox/10.0a1 Fennec/10.0a1
Devices: Samsung Galaxy Tab 10.1
OS: Android 3.1