676626 - server-full tests fail when nodes isn't installed

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Rob Miller [:rmiller]]

Running the tests with a fresh checkout of server-full gives the following failure:

======================================================================
ERROR: Failure: ImportError (No module named nodes)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/rob/tmp/server-full/lib/python2.6/site-packages/nose-1.1.2-py2.6.egg/nose/loader.py", line 390, in loadTestsFromName
    addr.filename, addr.module)
  File "/Users/rob/tmp/server-full/lib/python2.6/site-packages/nose-1.1.2-py2.6.egg/nose/importer.py", line 39, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/Users/rob/tmp/server-full/lib/python2.6/site-packages/nose-1.1.2-py2.6.egg/nose/importer.py", line 86, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/Users/rob/tmp/server-full/deps/server-sreg/syncsreg/tests/test_user.py", line 52, in <module>
    from nodes import NodeAttributionError
ImportError: No module named nodes

According to telliott, the nodes library shouldn't be required, and these tests should just be skipped in environments that don't have nodes installed.

Comment 1

[Tarek Ziadé (:tarek)]

The plan is to get rid of syncsreg in server-full, and yeah -- skip those tests in synreg if any

Comment 2

[Tarek Ziadé (:tarek)]

ah hum, it's a duplicate in fact

Comment 3

[Toby Elliott [:telliott]]

Reopening this, since it's not really a dupe (though the problems are related).

Having a node setup isn't a requirement of sreg, so the tests should reflect that by skipping. Ironically, all this stuff is coming out of reg and sreg shortly anyway, but in the interim, we should be correct about it.

Comment 4

[Toby Elliott [:telliott]]

Attachment: uses node test skip to skip nodes if there's no node lib defined

Comment 5

[Tarek Ziadé (:tarek)]

Comment on attachment 550862 [details] [diff] [review]
uses node test skip to skip nodes if there's no node lib defined

LGTM besides:

s/except Exception/except (KeyError, ImportError)/

(discussed on IRC)

Comment 6

[Tarek Ziadé (:tarek)]

Toby has pushed this here : https://hg.mozilla.org/services/server-sreg/rev/4eedc7954cbc