Profiler Patch for Android

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
7 years ago
3 days ago

People

(Reporter: akruetzf, Assigned: jbahuley)

Tracking

unspecified
Future
ARM
Android
Dependency tree / graph
Bug Flags:
flashplayer-injection -
flashplayer-qrb +
flashplayer-bug -

Details

(Whiteboard: loose-end)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

7 years ago
This patch is Scott's profiling addition for Android & Mac OS X
(Reporter)

Comment 1

7 years ago
Created attachment 550824 [details] [diff] [review]
Initial diff
Attachment #550824 - Flags: review?(speterse)
(Reporter)

Updated

7 years ago
Flags: flashplayer-qrb?

Updated

7 years ago
Flags: flashplayer-qrb?
Flags: flashplayer-qrb+
Flags: flashplayer-injection-
Flags: flashplayer-bug-
Priority: -- → P2

Updated

7 years ago
Assignee: nobody → akruetzf
Whiteboard: loose-end

Comment 2

7 years ago
Please ensure that the documentation on this change are accessible to the AS team.  THe original source is: https://zerowing.corp.adobe.com/display/flexsdk/Making+AS3+visible+to+Shark+and+oprofile
(Reporter)

Comment 3

7 years ago
Comment on attachment 550824 [details] [diff] [review]
Initial diff

Adding Rick for review
Attachment #550824 - Flags: review?(rreitmai)

Comment 4

7 years ago
Comment on attachment 550824 [details] [diff] [review]
Initial diff

interesting prototype work that is not ready to land.

- the JIT related pieces (e.g. JITobserver) should be moved out of the AvmCore (maybe into CodeMgr or Fragment?)
- contains cruft that needs clean up (fprintf, ifdef SECURITY)
- many new defines are introduced ad-hoc (e.g. VMCFG_APCS) and enabled directly in the code, altering behavior.
- verifier changes should be refactored out of this class.
- also if we're going to update our technique for housing info regarding the JIT it would be good to convert the VTUNE stuff to work with it.
- ARM codegen changes are a hack that needs fixing.
- lots of whitespace issues, tabs should be converted to space
- touches TR and NJ, so need to separate into at least 2 patches.
Attachment #550824 - Flags: review?(rreitmai) → review-

Updated

7 years ago
Assignee: akruetzf → jbahuley

Updated

7 years ago
Target Milestone: Q2 12 - Cyril → Q1 12 - Brannan
(Assignee)

Comment 5

7 years ago
I assume the APCS changes are only to allow oprofile to give call stack traces and not strictly required for the profiler to give JIT symbol information.
(Assignee)

Comment 6

7 years ago
Created attachment 572792 [details] [diff] [review]
JITObserver core changes

Framework for sending JIT information to profilers. Part 1/4. 

Subsequent patches will:

Add Oprofile, VTune support for Tamarin to be re-worked around JITObserver. Add APCS changes to Nanojit for getting call stacks on ARM.

Updated

7 years ago
Blocks: 686127

Comment 7

7 years ago
Created attachment 601989 [details] [diff] [review]
patch hunks with android-specific oprofile support

Bug 727955 contains profiling support for shark only.   Oprofile can be added with a few tweaks for arm and android.  (presumably oprofile on x86-linux can be supported easily too).

This patch contains the patch hunks with Arm APCS support (for arm stack walking) and ANDROID (for log file path and dl api tweaks)
Attachment #550824 - Attachment is obsolete: true
Attachment #572792 - Attachment is obsolete: true
Attachment #550824 - Flags: review?(speterse)

Updated

7 years ago
Depends on: 727955

Updated

7 years ago
OS: Mac OS X → Android
Priority: P2 → --
Hardware: x86 → ARM
Target Milestone: Q1 12 - Brannan → Future
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
Status: NEW → RESOLVED
Last Resolved: 3 days ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.