Closed Bug 676713 Opened 9 years ago Closed 9 years ago
Places browser-chrome tests should use head
.js:wait For Clear History instead of defining their own impl
As implemented by the patch for bug 564900, other mochitests in browser/components/places should use the |waitForClearHistory| function defined in head.js instead of defining their own version. At the time of this filing, the following tests can be refactored: browser_410196_paste_into_tags.js browser_library_panel_leak.js browser_forgetthissite_single.js browser_sidebarpanels_click.js browser_history_sidebar_search.js
Summary: Places mochitests should use head.js:waitForClearHistory instead of defining their own impl → Places browser-chrome tests should use head.js:waitForClearHistory instead of defining their own impl
Some of the implementations of waitForClearHistory passed extra arguments to the callback function, but none of the callback functions referenced these arguments. I ran all the tests locally and they still pass. Here is a link to the try server build: http://tbpl.mozilla.org/?tree=Try&rev=9fb5a88f71aa
Assignee: nobody → jwein
Status: NEW → ASSIGNED
Attachment #551495 - Flags: review?(mak77)
Comment on attachment 551495 [details] [diff] [review] Patch for bug 676713 Requesting review from sdwilsh since Marco is on vacation.
Attachment #551495 - Flags: review?(mak77) → review?(sdwilsh)
Comment on attachment 551495 [details] [diff] [review] Patch for bug 676713 http://hg.mozilla.org/mozilla-central/rev/a2b79dba6710
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.