676715 - test-private-browsing.testActivateDeactivate and .testStart time out

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

Two private-browsing tests started failing on all platforms after this recent merge from fx-team to central <http://tbpl.mozilla.org/?tree=Firefox&noignore=1&rev=0fbdefb0a9b5>:

info: executing 'test-private-browsing.testActivateDeactivate'
error: TEST FAILED: test-private-browsing.testActivateDeactivate (timed out)
console: [JavaScript Error: "TEST FAILED: test-private-browsing.testActivateDeactivate (timed out)
"]
info: executing 'test-private-browsing.testStart'
error: TEST FAILED: test-private-browsing.testStart (timed out)
console: [JavaScript Error: "TEST FAILED: test-private-browsing.testStart (timed out)
"]

http://hg.mozilla.org/mozilla-central/rev/1a9f0823fdba from bug 651643 is the obvious "changeset of interest" in this case.  This could be a regression from that change, but it seems more likely that we need to update the SDK tests to take the underlying change in behavior into account.

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/223

Pointer to Github pull-request

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 551411 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/223

Looks good, works, r=myk.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

https://github.com/mozilla/addon-sdk/commit/192eab036f3a75e7af01f4f534d7fea2a317ae9b

Comment 4

[Myk Melez [:myk] [@mykmelez]]

This doesn't actually happen on the Firefox branch that SDK 1.1 is targeting (currently, the beta branch), so we don't need to fix this for 1.1.