67672 - Invalid assignment of pointer to int in PlugletViewMotif.cpp

Status: VERIFIED WORKSFORME

(Core Graveyard :: Java-Implemented Plugins, defect)

Description

[Marcus Fellinger]

I'm currently trying to build BlackConnect. While compiling
java/plugins/src/PlugletViewMotif.cpp, I get the following warning:

PlugletViewMotif.cpp
c++ -I/usr/java/jdk1.3.0_01/include -I/usr/java/jdk1.3.0_01/include/linux
-DWIDGET_DLL=\"libwidget_gtk.so\" -DGFXWIN_DLL=\"libgfx_gtk.so\"
-I/usr/lib/glib/include -I/usr/X11R6/include -D_REENTRANT  -DOJI_DISABLE
-fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wbad-function-cast
-Wcast-align -Woverloaded-virtual -Wsynth -pedantic -Wno-long-long -pthread -O 
-DNDEBUG -DTRIMMED -o PlugletViewMotif.o -c -DOSTYPE=\"Linux2.2\" -DOJI  
-I../../../dist/include -I../../../dist/include      -I/usr/X11R6/include  
-fPIC  -I/usr/java/jdk1.3.0_01/include -I/usr/java/jdk1.3.0_01/include/linux
-DWIDGET_DLL=\"libwidget_gtk.so\" -DGFXWIN_DLL=\"libgfx_gtk.so\"
-I/usr/lib/glib/include -I/usr/X11R6/include -D_REENTRANT  -DOJI_DISABLE
-fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wbad-function-cast
-Wcast-align -Woverloaded-virtual -Wsynth -pedantic -Wno-long-long -pthread -O 
-DNDEBUG -DTRIMMED -DMOZILLA_CLIENT -include ../../../config-defs.h
-Wp,-MD,.deps/PlugletViewMotif.pp PlugletViewMotif.cpp
PlugletViewMotif.cpp: In method `PRBool
PlugletViewMotif::SetWindow(nsPluginWindow *)':
PlugletViewMotif.cpp:115: warning: initialization to `int' from `nsPluginPort *'
lacks a cast

I think that this should be fixed, because sizeof(void*) could be different from
sizeof(int), and a conversion from one to the other could remove significant
bits. Later, the ContainerWindowID assigned in line 115 is compared to WindowID,
which is intialised to 0, and if the two are equal, an error is reported. Now,
if ContainerWindowID is non-zero only in the bits  which the conversion removes,
the comparision will give a faulty result of true.

TIA,
Marcus Fellinger
Tomcat Computer GmbH

Comment 1

[Keyser Sose]

Marking NEW to get someone with more experience to look at it.

Comment 2

[Alexei V. Mokeev]

Changing QA contact

Comment 3

[Marcus Fellinger]

LXR doesn't find PlugletViewMotif.cpp anymore. Shouldn't this bug be claused as
the file doesn't exist anymore

Comment 4

[Alexei V. Mokeev]

Hi Marcus, 
PlugletViewMotif.cpp is present in sources and at the LXR:
http://lxr.mozilla.org/mozilla/source/java/plugins/src/PlugletViewMotif.cpp

But looks like this bug is already gone - it isn't reproduced.

Comment 5

[Marcus Fellinger]

Errr, sorry for that. I later noticed that I only looked for it in the Seamonkey
module. However, since the bug seems to have been fixed, it should probably be
marked as RESOLVED or VERIFIED?

Comment 6

[Alexei V. Mokeev]

Ok, please change state to RESOLVED and I'll verify it.

Comment 7

[Marcus Fellinger]

Marking as RESOLVED/WORKSFORME as by Alexeis comment

Comment 8

[Alexei V. Mokeev]

Verified.