Closed Bug 676727 Opened 8 years ago Closed 8 years ago

[RTL] urlbar styles are wrong in RTL locales

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 8

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

(Keywords: polish, rtl, Whiteboard: [inbound])

Attachments

(2 files)

Attached patch patchSplinter Review
This patch fixes a cosmetic issue with the Fennec location bar in RTL locales, where the borders between the endcaps and the text area are not drawn correctly.

You can test this by adding the following string preference in about:config:
user_pref("intl.uidirection.en", "ltr");

Looking at the code, it looks like this problem has been around a long time, possibly since before Fennec 4.0.
Attachment #550886 - Flags: review?(wjohnston)
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Comment on attachment 550886 [details] [diff] [review]
patch

Review of attachment 550886 [details] [diff] [review]:
-----------------------------------------------------------------

Looks pretty! There are apparently other places like this in platform.css files, but we've addressed rtl on most of those separately. I wonder if they're worth fixing up to use -moz-border-start/end as well.
Attachment #550886 - Flags: review?(wjohnston) → review+
http://hg.mozilla.org/mozilla-central/rev/ace0285541c4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:8.0a1) Gecko/20110807 Firefox/8.0a1 Fennec/8.0a1
Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.