676744 - Try syntax checking should be stricter

Status: RESOLVED DUPLICATE of bug 591688

(Release Engineering :: General, enhancement, P5)

Description

[Mats Palmgren (inactive)]

Please consider rejecting the following syntax (contains typo):
try: -b do -p all -u reftest,mochitests-4

It ran only reftest when I wanted reftest + mochitest-4.

Comment 1

[Justin Wood (:Callek)]

*or* we could relax the syntax to *allow* |mochitests-\d| such that a plural mistake here won't break expectations and cause more local churn. ;-)

Comment 2

[Mats Palmgren (inactive)]

Yeah, that works too in this case.  I'm more interested in getting the
general case fixed - when it ends with a comma followed by garbage.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

I'll file this as a potential try_enhancement though at the moment the primary try work is not focused on adding more and more casing to the try_parser.  That parser code is located here: http://hg.mozilla.org/build/buildbotcustom/file/tip/try_parser.py and patches are accepted if you can also write and pass tests added to here: http://hg.mozilla.org/build/buildbotcustom/file/tip/test/test_try_parser.py