676745 - Hand-composed .signature lost when switching From: account

Status: RESOLVED DUPLICATE of bug 218346

(Thunderbird :: Message Compose Window, defect)

Description

[era+mozilla]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20110504 Firefox/4.0.1
Build ID: 20110504035914

Steps to reproduce:

I wrote a new email message, including a .signature, then switched to a different From: address.


Actual results:

The .signature text I had just finished composing was lost.


Expected results:

A .signature which was edited, rather than just inserted from a file by Thunderbird, should not be discarded when switching to a different From: address.

Comment 1

[era+mozilla]

For context, here are some related bugs, mainly of tangential interest.

Bug 75497 - Old signature isn't overwritten by new signature on switching account Bug 566825 - Multiple signatures when switching between accounts (signature of previously selected account is not removed) in plaintext editor
Bug 218346 - Switch from an identity set to have signature above the quote, or with suppress_signature_separator set, results in multiple sig's

Comment 2

[rsx11m]

I would see this as another manifestation of bug 218346, the algorithm to identify an "old" signature for removal is too simple and just looks for the signature separator. Per suggestion in bug 58406 comment #198:

> On HTML composition this is fine, as we can detect the start of the signature
> via a class name on an html node. With plain text composition, we were
> detecting the "-- " as the start of the signature. [...] the potential solution
> would be to look for the whole signature and remove that.

If implemented in bug 218346, this would also take care of the issue described here as a modified signature would be detected as such and not removed.