Improve string for 32-bit plugin restart.

RESOLVED FIXED in seamonkey2.5

Status

RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: philip.chee, Assigned: philip.chee)

Tracking

Trunk
seamonkey2.5

SeaMonkey Tracking Flags

(seamonkey2.5 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 years ago
ref Firefox Bug 656152: Improve string for 32-bit plugin restart.
(Assignee)

Comment 1

8 years ago
Created attachment 550995 [details] [diff] [review]
Patch v1.0

Someone was too clever by half when writing notification.xml, mutter mutter.
Again need a Mac OS X person to test this patch.
Attachment #550995 - Flags: review?(stefanh)
Attachment #550995 - Flags: review?(neil)
(Assignee)

Comment 2

7 years ago
Created attachment 551087 [details] [diff] [review]
Patch v1.1 Simpler patch.

<NeilAway>	can't we just post a note to localisers suggesting that they might want to change the wording slightly?
<NeilAway>	do we have a mailing list for seamonkey localisers? I don't want to keep annoying just one of them all the time
<KaiRo>	mozilla.dev.l10n
Attachment #550995 - Attachment is obsolete: true
Attachment #550995 - Flags: review?(stefanh)
Attachment #550995 - Flags: review?(neil)
Attachment #551087 - Flags: review?(stefanh)
Attachment #551087 - Flags: review?(neil)
(In reply to Philip Chee from comment #2)
> <NeilAway>	can't we just post a note to localisers suggesting that they
> might want to change the wording slightly?
> <NeilAway>	do we have a mailing list for seamonkey localisers? I don't want
> to keep annoying just one of them all the time
> <KaiRo>	mozilla.dev.l10n

Shame you failed to read the note carefully enough ;-)
(Assignee)

Comment 4

7 years ago
Didn't see the note.

> On 05.08.11 13:53, Neil wrote:
>>> suite/locales/en-US/chrome/common/notification.properties
>>> carbonfailurepluginsMessage.title=This page requires a plugin that can
>>> only run in 32-bit mode.
>>>
>>> Someone wants to change the word "requires" to "requests". Unfortunately
>>> due to the way I wrote the code that reads the string, I can't easily
>>> rename the string, because that involves renaming other strings which
>>> haven't changed. Is the sky really going to fall in if I don't rename
>>> it? Will you guys mind renaming a bunch of strings that haven't really
>>> changed?
>>>
> I would think that both are totally fine, they just show a slightly 
> different political view on flash from the author ;-). I'd suggest to 
> keep the key as is and to add a comment suggesting that localizers can 
> use a word corresponding to one or both, depending on what matches the 
> language best.
> 
> Axel
(Assignee)

Comment 5

7 years ago
Created attachment 551124 [details] [diff] [review]
Patch v1.2 with localization note.

> Didn't see the note.
Have now read the note and added a localization note.
Attachment #551087 - Attachment is obsolete: true
Attachment #551087 - Flags: review?(stefanh)
Attachment #551087 - Flags: review?(neil)
Attachment #551124 - Flags: review?(stefanh)
Attachment #551124 - Flags: review?(neil)
Comment on attachment 551124 [details] [diff] [review]
Patch v1.2 with localization note.

>-carbonfailurepluginsMessage.title=This page requires a plugin that can only run in 32-bit mode.
>+carbonfailurepluginsMessage.title=This page requests to use a plugin that can only run in 32-bit mode.
Oops. s/requires/requests/ only, not "requests to use"! r=me with that fixed.
Attachment #551124 - Flags: review?(neil) → review+

Comment 7

7 years ago
Comment on attachment 551124 [details] [diff] [review]
Patch v1.2 with localization note.

What Neil said (good that it doesn't change the length of the string).
Attachment #551124 - Flags: review?(stefanh) → review+
(Assignee)

Comment 8

7 years ago
> Oops. s/requires/requests/ only, not "requests to use"! r=me with that fixed.
Fixed.

Pushed.
http://hg.mozilla.org/comm-central/rev/c63fefad39c0
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
status-seamonkey2.5: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5
You need to log in before you can comment on or make changes to this bug.