67682 - Add mozctlx.dll to build & install

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Adam Lock]

Mozctlx.dll is a new "bootstrap" DLL that enables the Mozilla control to be used 
without changing PATH environment variables, rebooting etc. It should be made 
part of the nightly builds and installed with mozctl.dll.

Comment 1

[Sean Su]

The xpinstall team is not responsible in adding files to the build system or to
be installed.  The developer of the files need to make sure of that.

To make sure the file gets installed properly, just make sure that the file is
delivered to $DIST and the ...\xpinstall\packager\packages-win is updated to
include either the dir of where the file(s) reside or the file(s) themselves (it
sounds like it should be in the [browser] section).  The installer build process
will take care of the rest.

Comment 2

[Adam Lock]

Attachment: Patches to add mozctlx.dll to build & package install

Comment 3

[Scott Collins]

Cool, but what are the ramifications?  Does this dll unload after it's done it's
work?  Maybe it's so small it doesn't matter?

sr=scc

Comment 4

[Adam Lock]

Thanks Scott!

It does this.

When you register mozctlx.dll:

1. Asks you where the moz bin directory path is.
2. Stores that path in the registry
3. Appends the path to the PATH environment variable in the host process 
(regsvr32)
4. Loads the real mozctl.dll
5. Calls DllRegisterServer on it.
6. Fixes up the registry entry so mozctlx.dll will be loaded instead of 
mozctl.dll to create the control.

When a control instance is created (via DllGetClassObject

1. Loads the moz bin directory path from the registry
2. Fixes up the PATH
3. Loads mozctl.dll
4. Calls DllGetClassObject in mozctl.dll to the caller

The host process should unload mozctlx.dll when a call to DllCanUnloadNow() says 
it can. Since mozctlx.dll maps the call through to mozctl.dll they should both 
unload at the same time.

Comment 5

[Adam Lock]

Fix checked in. Verify by checking that mozctlx.dll is installed by the 
installer.

Comment 6

[Grace Bush]

mozctlx.dll being installed on build 2001021309