676842 - nsTextEditorState.h should include nsString.h

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[arno renevier]

Hi,
When trying to include nsTextEditorState.h in a file which does not include (directly or indirectly nsString.h), compilation fails:
/home/arno/mozilla/content/html/content/src/nsTextEditorState.h:269:13: error: ‘nsCString’ was not declared in this scope
/home/arno/mozilla/content/html/content/src/nsTextEditorState.h:269:22: error: template argument 1 is invalid
/home/arno/mozilla/content/html/content/src/nsTextEditorState.h:271:11: error: ‘nsString’ does not name a type
/home/arno/mozilla/content/html/content/src/nsTextEditorState.h: In member function ‘void nsTextEditorState::EmptyValue()’:
/home/arno/mozilla/content/html/content/src/nsTextEditorState.h:163:41: error: base operand of ‘->’ is not a pointer
/home/arno/mozilla/content/html/content/src/nsTextEditorState.h: In member function ‘PRBool nsTextEditorState::IsEmpty() const’:
/home/arno/mozilla/content/html/content/src/nsTextEditorState.h:164:50: error: base operand of ‘->’ is not a pointer
/home/arno/mozilla/content/html/content/src/nsTextEditorState.h: In member function ‘void nsTextEditorState::ClearValueCache()’:
/home/arno/mozilla/content/html/content/src/nsTextEditorState.h:213:28: error: ‘mCachedValue’ was not declared in this scope

Comment 1

[arno renevier]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

A good practice that helps avoid problems of this sort is to make each class-specific .h file the first #include in its .cpp file.  In other words, if nsTextEditorState.h were the first #include in nsTextEditorState.cpp, this wouldn't have happened.

Comment 3

[arno renevier]

Attachment: updated patch: make nsTextEditorState.h first include of nsTextEditorState.cpp

Comment 4

[(no longer active)]

Landed the patch on mozilla-inbound.  Thanks for writing the patch!

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/d7db60b35edc