676856 - show package name in about:buildconfig on Android

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 551082 [details] [diff] [review]
patch

>diff --git a/toolkit/content/Makefile.in b/toolkit/content/Makefile.in

>+ifeq (Android,$(OS_TARGET))
>+DEFINES += \
>+  -DANDROID_PACKAGE_NAME=$(ANDROID_PACKAGE_NAME) \
>+  -DANDROID=1 \

I don't think the -DANDROID=1 is needed here, given that ANDROID is AC_DEFINED in configure? (It also looks like ANDROID_PACKAGE_NAME could benefit from being globally defined, given its use all over the place.)

Who is this information useful to? Seems a bit odd to just dump it at the end of about:buildconfig. If it's even remotely end-user-relevant, perhaps it should go into about:support under "Application Basics" instead?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

dougt pointed out that this would be useful after bug 676723 lands to confirm you're running the build you think you're running. So it will presumably be used by mobile developers who are installing builds from other mobile developers.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/57b361988a3a

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/57b361988a3a

Comment 6

[Aaron Train [:aaronmt]]

Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110811 Firefox/8.0a1 Fennec/8.0a1