Closed Bug 676856 Opened 8 years ago Closed 8 years ago

show package name in about:buildconfig on Android

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 8

People

(Reporter: blassey, Assigned: blassey)

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Assignee: nobody → blassey.bugs
Attachment #551082 - Flags: review?(gavin.sharp)
Status: NEW → ASSIGNED
Comment on attachment 551082 [details] [diff] [review]
patch

>diff --git a/toolkit/content/Makefile.in b/toolkit/content/Makefile.in

>+ifeq (Android,$(OS_TARGET))
>+DEFINES += \
>+  -DANDROID_PACKAGE_NAME=$(ANDROID_PACKAGE_NAME) \
>+  -DANDROID=1 \

I don't think the -DANDROID=1 is needed here, given that ANDROID is AC_DEFINED in configure? (It also looks like ANDROID_PACKAGE_NAME could benefit from being globally defined, given its use all over the place.)

Who is this information useful to? Seems a bit odd to just dump it at the end of about:buildconfig. If it's even remotely end-user-relevant, perhaps it should go into about:support under "Application Basics" instead?
Attachment #551082 - Flags: review?(gavin.sharp) → review+
dougt pointed out that this would be useful after bug 676723 lands to confirm you're running the build you think you're running. So it will presumably be used by mobile developers who are installing builds from other mobile developers.
http://hg.mozilla.org/mozilla-central/rev/57b361988a3a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 8
Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110811 Firefox/8.0a1 Fennec/8.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.