Closed Bug 676940 Opened 13 years ago Closed 13 years ago

IonMonkey: Linear scan register allocator can insert moves before the LLabel of a block

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: adrake, Unassigned)

Details

Attachments

(1 file)

Attached patch Patch v0Splinter Review
This trips an assert later in the code generator. There's no real gain to having Labels be instructions in SSA form, so we can just pull them out into the block and skip the whole LLabel mess.
Attachment #551156 - Flags: review?(dvander)
Comment on attachment 551156 [details] [diff] [review]
Patch v0

Review of attachment 551156 [details] [diff] [review]:
-----------------------------------------------------------------

I love it that we're deleting gobs of code already.
Attachment #551156 - Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/679524cb3937
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.