Closed
Bug 677026
Opened 13 years ago
Closed 6 years ago
nsIDOMWindow should inherit nsIDOMEventTarget
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 2 obsolete files)
3.72 KB,
patch
|
Details | Diff | Splinter Review | |
11.90 KB,
patch
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #551256 -
Flags: review?(jonas)
Attachment #551256 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Grr, tbox doesn't like the patch. Seems like nsIDOMWindow.idl can't find nsIDOMEventTarget.idl
Assignee | ||
Comment 3•13 years ago
|
||
So DOMWindow needs to find DOMEventTarget. Either interfaces/events needs to be processed before interfaces/base, and interfaces/events must not refer to anything in interfaces/base (like domstubs), or we just move this one interface to base/. This is the easiest fix I could find: move nsIDOMEventTarget (which is becoming a kind of base interface for many DOM interfaces) to base/. I didn't notice this problem earlier, since it happens only with clobber builds.
Attachment #551271 -
Flags: review?(jonas)
I think you can just add 'XPIDL_FLAGS += -I$(topsrcdir)/dom/interfaces/events' in dom/interfaces/base's Makefile.
Assignee | ||
Comment 5•13 years ago
|
||
Testing that...
Assignee | ||
Comment 6•13 years ago
|
||
Ok, this works. Who would new about XPIDL_FLAGS. It is used so rarely.
Attachment #551256 -
Attachment is obsolete: true
Attachment #551271 -
Attachment is obsolete: true
Attachment #551271 -
Flags: review?(jonas)
(In reply to Olli Pettay [:smaug] from comment #6) > Who would new about XPIDL_FLAGS. It is used so rarely. The guy who hacks on the IDL compiler? ;-)
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #6) > Who would new about XPIDL_FLAGS. It is used so rarely. 'new'? Huh, how did I type that.
Assignee | ||
Comment 9•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e6e47912000d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•13 years ago
|
||
Still no good. About to back out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 11•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b422fd99fe0d
Updated•13 years ago
|
Hardware: x86_64 → All
Version: unspecified → Trunk
Assignee | ||
Comment 12•13 years ago
|
||
Comment 13•13 years ago
|
||
Should this be resolved fixed? From comment 11, it looks like it relanded and wasn't backed out.
Assignee | ||
Comment 14•13 years ago
|
||
This isn't in the tree.
Comment 15•12 years ago
|
||
Might be this also needs to change nsWindowSH::InstallGlobalScopePolluter; I don't think we want EventTarget to inherit from the gsp.
Comment 16•12 years ago
|
||
That's correct. Per WebIDL, the proto chain should look like this: window object -> Window.prototype -> GSP -> EventTarget.prototype -> Object.prototype
Comment 17•6 years ago
|
||
nsIDOMEventTarget is gone. nsIDOMWindow will go away too, at some point.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 6 years ago
Resolution: --- → WONTFIX
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•