Closed Bug 677026 Opened 9 years ago Closed 2 years ago
IDOMWindow should inherit ns IDOMEvent Target
Attachment #551256 - Flags: review?(jonas) → review+
Grr, tbox doesn't like the patch. Seems like nsIDOMWindow.idl can't find nsIDOMEventTarget.idl
So DOMWindow needs to find DOMEventTarget. Either interfaces/events needs to be processed before interfaces/base, and interfaces/events must not refer to anything in interfaces/base (like domstubs), or we just move this one interface to base/. This is the easiest fix I could find: move nsIDOMEventTarget (which is becoming a kind of base interface for many DOM interfaces) to base/. I didn't notice this problem earlier, since it happens only with clobber builds.
I think you can just add 'XPIDL_FLAGS += -I$(topsrcdir)/dom/interfaces/events' in dom/interfaces/base's Makefile.
Ok, this works. Who would new about XPIDL_FLAGS. It is used so rarely.
(In reply to Olli Pettay [:smaug] from comment #6) > Who would new about XPIDL_FLAGS. It is used so rarely. The guy who hacks on the IDL compiler? ;-)
(In reply to Olli Pettay [:smaug] from comment #6) > Who would new about XPIDL_FLAGS. It is used so rarely. 'new'? Huh, how did I type that.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Still no good. About to back out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Should this be resolved fixed? From comment 11, it looks like it relanded and wasn't backed out.
This isn't in the tree.
Might be this also needs to change nsWindowSH::InstallGlobalScopePolluter; I don't think we want EventTarget to inherit from the gsp.
That's correct. Per WebIDL, the proto chain should look like this: window object -> Window.prototype -> GSP -> EventTarget.prototype -> Object.prototype
nsIDOMEventTarget is gone. nsIDOMWindow will go away too, at some point.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.