[Java] NullPointerException in GeckoApp.onNewIntent()

RESOLVED FIXED in Firefox 8

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mfinkle, Assigned: blassey)

Tracking

Firefox 6
Firefox 8
ARM
Android

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

v6.0 Aug 7, 2011 12:24:13 AM 1 reports/week 0 %1 reports 
--------------------------------------------------------------------------------

java.lang.NullPointerException
at org.mozilla.gecko.GeckoApp.onNewIntent(GeckoApp.java:284)
at android.app.Instrumentation.callActivityOnNewIntent(Instrumentation.java:1122)
at android.app.ActivityThread.deliverNewIntents(ActivityThread.java:1812)
at android.app.ActivityThread.performNewIntents(ActivityThread.java:1825)
at android.app.ActivityThread.handleNewIntent(ActivityThread.java:1834)
at android.app.ActivityThread.access$2300(ActivityThread.java:123)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1040)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:126)
at android.app.ActivityThread.main(ActivityThread.java:3997)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:491)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:841)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:599)
at dalvik.system.NativeStart.main(Native Method)

Comment 1

7 years ago
I haven't looked at the offending line in the proper revision, but http://mxr.mozilla.org/mozilla-central/source/embedding/android/GeckoApp.java#321 looks like a troublemaker.
Created attachment 551331 [details] [diff] [review]
patch

jdm, I think you're right
Assignee: nobody → blassey.bugs
Attachment #551331 - Flags: review?(doug.turner)

Comment 3

7 years ago
Is |action| sometimes null?
If no action for the intent is specified, then it will be null.

http://developer.android.com/reference/android/content/Intent.html#getAction%28%29

Comment 5

7 years ago
Comment on attachment 551331 [details] [diff] [review]
patch

Review of attachment 551331 [details] [diff] [review]:
-----------------------------------------------------------------

extra points for making a final of the string on:
  http://mxr.mozilla.org/mozilla-central/source/embedding/android/GeckoApp.java#294

mostly to be consistent with the other checks.
Attachment #551331 - Flags: review?(doug.turner) → review+
http://hg.mozilla.org/mozilla-central/rev/d9d5fbe6e0f2
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
You need to log in before you can comment on or make changes to this bug.