Closed
Bug 67709
Opened 24 years ago
Closed 24 years ago
Assertion on each character typed in editor
Categories
(Core :: DOM: Editor, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla0.8
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(2 files)
6.15 KB,
text/plain
|
Details | |
914 bytes,
patch
|
Details | Diff | Splinter Review |
On a current CVS build on Linux, I get an assertion for every single character I
type in mail compose (plaintext). Attaching a stacktrace.
Assignee | ||
Comment 1•24 years ago
|
||
Comment 2•24 years ago
|
||
i dont get any assertions on an older build that is nonetheless after my large
embedding landing. hmmm. does this happen on any other platform? I'm on mac
and have a windows box, but not linux.
kin, akkana, does this happen for you?
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla0.8
Comment 3•24 years ago
|
||
I don't see this assertion in today's build. I think I did see it sometime late
last week.
Assignee | ||
Comment 4•24 years ago
|
||
Actually, I'm seeing this in Composer and in HTML mail compose also (but not
typing in textareas). Changing summary.
Summary: Assertion on each character typed in plaintext mail compose → Assertion on each character typed in editor
Comment 5•24 years ago
|
||
my best guess so far is bryner's tree is somehow stale. this problem did exist
breifly after my landing, but was quickly fixed. he said he hasn't done a
clobber build in a while - my money is on that.
Assignee | ||
Comment 6•24 years ago
|
||
This bug is due to the variable rv never being initialized in
nsHTMLEditRules::BeforeEdit. It doesn't look like this variable is really
needed, anyway, so I just got rid of it (patch coming up).
Assignee | ||
Comment 7•24 years ago
|
||
Comment 8•24 years ago
|
||
r=blake
Yeah, I saw this assertion too. r=dbaron. do_QueryInterface always assigns
0 on failure so the null-check should be sufficient.
Assignee | ||
Comment 10•24 years ago
|
||
reassigning to me
Assignee: jfrancis → bryner
Status: ASSIGNED → NEW
Comment 11•24 years ago
|
||
Assignee | ||
Comment 12•24 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 13•24 years ago
|
||
Brian, thanks for tracking this down!
Comment 14•24 years ago
|
||
bryner, is this working for you now ? please mark this bug verified-fixed
if so....thanks...
You need to log in
before you can comment on or make changes to this bug.
Description
•