Make use of Harmattan Backup System

RESOLVED FIXED in Firefox 8

Status

Firefox for Android Graveyard
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jbos, Unassigned)

Tracking

Trunk
Firefox 8
x86
Linux

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

7 years ago
Created attachment 551445 [details] [diff] [review]
Adds Harmattan Backupsystem

This add some scripts to fennec mobile installer which get installed in the correct places of harmattan. 
Those scripts will allow fennec to get backuped during the system-backup.

You need to enable it in mozconfig by using:

ac_add_options --enable-harmattanbackup
(Reporter)

Updated

7 years ago
Attachment #551445 - Flags: review?(romaxa)
(Reporter)

Comment 1

7 years ago
Created attachment 551446 [details] [diff] [review]
Adds Harmattan Backupsystem
Attachment #551445 - Attachment is obsolete: true
Attachment #551445 - Flags: review?(romaxa)
Attachment #551446 - Flags: review?(romaxa)
Comment on attachment 551446 [details] [diff] [review]
Adds Harmattan Backupsystem

It looks weird all these separate enablers (content-manager/backup et.c) for harmattan specific build...
I think it should be 
1) Mobile GTK (aka Maemo5)
  - N900 specific stuff define (hildon/et.c)
2) Mobile Qt (aka Maemo6) - include common build for Pure Qt mobile...
  - Harmattan define (include content manager/backup et.c....)
  - Meego (something else)
  - Possibly Palm specific stuff for Palm Qt builds...
Comment on attachment 551446 [details] [diff] [review]
Adds Harmattan Backupsystem

Move this just under maemo6 define, don't introduce new config options... because we are not going to install maemo6 debian package anywhere else...
Attachment #551446 - Flags: review?(romaxa) → review-
(Reporter)

Comment 4

7 years ago
alright. But I will keep "enable option". Or what do you think?
No enable option needed... if it is harmattan (maemo6) and we think that backup must be enabled then we enable it no matter what...
(In reply to Oleg Romashin (:romaxa) from comment #5)
> No enable option needed... if it is harmattan (maemo6) and we think that
> backup must be enabled then we enable it no matter what...

Agreed
(Reporter)

Comment 7

7 years ago
Created attachment 551704 [details] [diff] [review]
Removed enable stuff, makes default on for Maemo 6
Attachment #551446 - Attachment is obsolete: true
Attachment #551704 - Flags: review?(romaxa)
Comment on attachment 551704 [details] [diff] [review]
Removed enable stuff, makes default on for Maemo 6

We should use MOZ_APP_NAME, instead of raw "fennec" here.
Attachment #551704 - Flags: review?(romaxa) → review-
Also you should create .in files, add filter template (MOZ_APP_NAME), and pre-process it here
(Reporter)

Comment 10

7 years ago
Created attachment 552341 [details] [diff] [review]
Redo and fixed comments
Attachment #551704 - Attachment is obsolete: true
Attachment #552341 - Flags: review?(romaxa)
(Reporter)

Comment 11

7 years ago
Created attachment 552613 [details] [diff] [review]
Fixed Head
Attachment #552341 - Attachment is obsolete: true
Attachment #552341 - Flags: review?(romaxa)
Attachment #552613 - Flags: review?(romaxa)
Attachment #552613 - Flags: review?(romaxa) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/56eaf58dc5fb
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.