677248 - netwerk/test/urltest.cpp seems to be unmaintained

Status: RESOLVED WORKSFORME

(Core :: Networking, defect, P5)

Description

[Julian Reschke]

urltest.cpp seems to be unmaintained. It's not run; and it it is run will fail because of IMHO broken use of fgets().

To get it running I had to change 

     while (fgets(temp,512,testfile))
     {
+        // remove newline
+        temp[strlen(temp)-1] = 0;
+
         if (*temp == '#' || !*temp)
             continue;

So \n is removed from the buffer before proceeding. Even with this change I get test failures, probably because the expected results have not been maintained.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Most of the standard tests should be able to move straight into test_URIs.js if they're not already covered, and probably the external tests as well.

Comment 2

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

File has been removed