677308 - Implement favicon change notifications

Status: RESOLVED WONTFIX

(Toolkit :: Places, defect)

Description

[Richard Newman [:rnewman]]

For Sync favicon support (Bug 428378) and also for Win7 jumplists.

Note from bbondy:

---
An observer for changed favicons would be great, I would already use it for the Win7 jump list code.  Do you have a bug ID for it?  Or is it covered by one of the mentioned Bug IDs below?

The win7 jump list requires that we have ICO files on disk, so I periodically re-cache out the files to disk after some constant time period in preferences.   If you hae a bug ID for the observer I'd like to post a new task to update the jump list code and set it's depends on to your bug.    Alternately, a callback that would only be called if the icon is newer than a timestamp I provide would be good.
---

Sync needs to know when favicons have changed so that they can be propagated to other devices, and I'm guessing that won't be possible purely through history and bookmark notifications.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I assume onPageChanged notification doesn't satisfy these needs

Comment 2

[Brian R. Bondy [:bbondy]]

I think nsINavHistoryObserver::onPageChanged would work just fine for my case.  Thanks!  I guess the only better thing would be for me to only be notified on the pages I cared about after I told the service which ones I cared about, but I think it's better for me to just use this.

Comment 3

[Richard Newman [:rnewman]]

Mak: are favicons ever changed (e.g., reloaded, expired) without an onPageChanged notification being fired?

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Richard Newman [:rnewman] from comment #3)
> Mak: are favicons ever changed (e.g., reloaded, expired) without an
> onPageChanged notification being fired?

well, we usually update them through browser requests, that means they are associated to the currently visited page.  The API allows to change data through SetFaviconData or SetFaviconDataFromDataURL and those don't notify (may be changed though). ExpireAllFavicons sends a places-favicons-expired topic through observer svc too, but doesn't notify single changes.